Create Task
Maniphest T208560

If a user is partially blocked they should be able to perform rollback on unrelated pages
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Screenshot (2).png (1×1 px, 255 KB)

Problem:
Tested on Nov. 1, 2018 on testwiki

An attempt to rollback the edits of a page got the error message that roll back was not allowed. See image of error message.

Expected behavior:

When a user is partially blocked they should be able to roll back edits on other unrelated pages.

Related Objects
Search...

Event Timeline

• SPoore created this task.Nov 2 2018, 12:05 AM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptNov 2 2018, 12:05 AM
• TBolliger triaged this task as Medium priority.Nov 2 2018, 12:15 AM
• TBolliger moved this task from Untriaged to Product/Tech backlog on the Anti-Harassment-Team board.
dbarratt added a project: MediaWiki-User-management.Nov 2 2018, 1:13 AM
jrbs renamed this task from If an admin is partially blocked they should be able to do roll back on unrelatetd pages to If an admin is partially blocked they should be able to perform rollback on unrelated pages.Nov 2 2018, 1:44 AM
jrbs subscribed.

This probably isn’t limited to admins, right? Can regular users with rollback perform rollbacks while partially blocked?

Krenair subscribed.Nov 2 2018, 1:45 AM
dmaza subscribed.Nov 2 2018, 3:48 AM
In T208560#4714965, @jrbs wrote:

This probably isn’t limited to admins, right? Can regular users with rollback perform rollbacks while partially blocked?

It is not limited to admins. If partially blocked no user can perform rollbacks on any pages regardless of groups/permissions.

jrbs renamed this task from If an admin is partially blocked they should be able to perform rollback on unrelated pages to If a user is partially blocked they should be able to perform rollback on unrelated pages.Nov 2 2018, 3:49 AM
jrbs updated the task description. (Show Details)
dmaza mentioned this in T208509: Partially blocked admins should be able to revision delete on unrelated pages, and oversighters should be able to suppress content.Nov 2 2018, 4:14 AM
• TBolliger moved this task from Backlog to User blocking on the MediaWiki-User-management board.Nov 2 2018, 4:14 PM
• TBolliger raised the priority of this task from Medium to High.Nov 2 2018, 4:40 PM
• TBolliger moved this task from Product/Tech backlog to Triage/To be Estimated on the Anti-Harassment-Team board.
• TBolliger added a parent task: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.Nov 2 2018, 4:45 PM
dbarratt removed a parent task: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.Nov 2 2018, 5:21 PM
dbarratt added a subtask: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.Nov 2 2018, 5:24 PM
• TBolliger mentioned this in T208613: 👩‍👦‍👦 Partial blocks complete blockers for ITWP release.Nov 2 2018, 5:55 PM
dbarratt added a parent task: T208613: 👩‍👦‍👦 Partial blocks complete blockers for ITWP release.Nov 2 2018, 5:57 PM
• TBolliger moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.Nov 2 2018, 6:20 PM
• TBolliger set the point value for this task to 3.
• TBolliger edited projects, added Anti-Harassment-Team (AHT Sprint 33); removed Anti-Harassment-Team.Nov 7 2018, 10:10 PM
dbarratt added a subtask: T208862: Title::checkUserBlock should call User::isBlockedFrom for every action that requires unblock.Nov 7 2018, 10:14 PM
dbarratt subscribed.

This should be resolved when T208862 is complete.

dbarratt changed the task status from Open to Stalled.Nov 8 2018, 10:22 PM
• TBolliger subscribed.Nov 9 2018, 6:52 PM

This is not fixed via T208862 on https://thegoodplace.wmflabs.org/wiki/Main_Page

Screen Shot 2018-11-09 at 10.50.32 AM.png (928×1 px, 139 KB)

dbarratt claimed this task.Nov 12 2018, 2:46 PM
dbarratt moved this task from Ready to In progress on the Anti-Harassment-Team (AHT Sprint 33) board.
dbarratt edited subtasks, added: T209284: Action::checkCanExecute should only block an Action if the user is sitewide blocked; removed: T208862: Title::checkUserBlock should call User::isBlockedFrom for every action that requires unblock.Nov 12 2018, 2:59 PM

RollbackAction extends FormlessAction which extends Action

requiresUnblock() returns the default value, true

dbarratt removed dbarratt as the assignee of this task.Nov 12 2018, 3:00 PM
dbarratt moved this task from In progress to Ready on the Anti-Harassment-Team (AHT Sprint 33) board.
dbarratt assigned this task to • TBolliger.Nov 15 2018, 5:17 PM
dbarratt moved this task from Ready to Review on the Anti-Harassment-Team (AHT Sprint 33) board.
• TBolliger closed this task as Resolved.Nov 15 2018, 5:48 PM
• TBolliger moved this task from Review to Done on the Anti-Harassment-Team (AHT Sprint 33) board.

Works as expected on thegoodplace test wiki, as of yesterday.

• TBolliger reopened subtask T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org as Open.Nov 19 2018, 9:49 PM
• TBolliger closed subtask T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org as Resolved.Nov 19 2018, 10:00 PM
dbarratt closed subtask T209284: Action::checkCanExecute should only block an Action if the user is sitewide blocked as Resolved.Nov 19 2018, 11:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits