We prove the existence of a maximum for your functional, and we show that the function you found is indeed the only point of maximum.
Existence of a maximum.
For each measurable $f\colon [0,1]\rightarrow [-1,1]$ we can associate the Lipschitz function $F\colon [0,1]\rightarrow [-1,1]$ given by
$$F(x):=\int_0^x f(t) \ dt$$
Note that
- $F(0)=0$,
- $|F(x)-F(y)|\leq |x-y|$,
Moreover every function $F$ satisfying $1-2$ is associated to an unique function $f\in L^\infty$ given by $f=F'$, with $f(x)\in [-1,1]$ almost everywhere. One can see that
$$\int_0^1 f(t) \ dt=F(1),$$
$$\int_0^1 t f(t) \ dt = \int_0^1 t F'(t) \ dt = F(1) - \int_0^1 F(t) \ dt.$$
Consider the condition
- $F(1) - \int_0^1 F(t) \ dt =0$.
Let $\mathcal{F}$ be the family of functions that satisfies $1-2-3$. By Ascoli-Arzelá Theorem this is a compact subset of functions in $C^0[0,1]$. So the continuous linear functional
$$F\in C^0[0,1]\mapsto F(1)$$
has points of maximum in $\mathcal{F}$. Since $F\in \mathcal{F}\implies -F \in \mathcal{F}$, it is easy to see that the maximum value is no negative.
Note that $F_0$ is a point of maximum of this problem if and only if $f_0=F_0'$ is a point of maximum of your original problem.
Finding the points of maximum: there is only one point of maximum.
Let $F_0$, with $f_0=F_0'$, be a point of maximum.
Claim 1. We claim that $|f_0|=1$ almost everywhere.
Otherwise there is $\epsilon\in (0,1]$ such that
$$m(\Omega_\epsilon)> 0,$$
where
$$\Omega_\epsilon:=\{x\in [0,1]\colon f_0(x)\in [-1+\epsilon,1-\epsilon] \}.$$
Then there is $c\in (0,1)$ such that
$$\int_0^c t 1_{\Omega_\epsilon}(t) \ dt = \int_c^1 t 1_{\Omega_\epsilon}(t) \ dt$$
Define
$$h = \frac{\epsilon}{2} \left( 1_{\Omega_\epsilon \cap [0,c]}- 1_{\Omega_\epsilon \cap [c,1]}\right).$$
Then
$$\int_0^1 t h(t) dt =0,$$
$$\int_0^1 h(t) dt > 0,$$
$g(x):=f_0(x)+h(x)\in[-1,1]$ and
$$\int_0^1 g(t) dt > \int_0^1 f(t) dt,$$
that contradicts the maximality of $f_0$. This proves the claim.
Claim 2. There is $c\in (0,1)$ such that
$$\{x\in [0,1]\colon f_0(x)=1\}=[0,c]$$
and
$$\{x\in [0,1]\colon f_0(x)=-1\}=[c,1]$$
up to subsets of zero Lebesgue measure.
Indeed, suppose this does not occur. Then there are two disjoint subsets $A$ and $B$ with positive Lebesgue measure and $d\in (0,1)$ such that
$A\subset [0,d]$, $B\subset [d,1]$, $f_0(x)=-1$ on $A$, and $f_0(x)=1$ on $B$. Reducing $A$ and $B$ if necessary we can assume that
$$\int t 1_A(t) \ dt = \int t 1_B(t) \ dt > 0$$.
Note that $m(A) > m(B)$. Then
$$h = \frac{1}{2} \left(1_A- 1_B\right)$$
satisfies
$$\int_0^1 t h(t) \ dt =0,$$
$$\int_0^1 h(t) \ dt > 0,$$
$g(x) = f_0(x)+ h(x)\in [-1,1]$ and we have
$$\int_0^1 g(t) \ dt > \int_0^1 f_0(t) \ dt,$$
that contradicts the maximality of $f_0$.
This concludes the proof of the second claim. Now it is easy to show that the only possible choice for $c$ in the second claim is $c=1/\sqrt{2}.$
So there is only one point of maximum, and the maximum value is $\sqrt{2}-1$.
Final Remark. The argument seems to be fairly general. For instance we could replace the condition
$$\int_0^1 t f(t) \ dt=0$$
by the condition
$$\int_0^1 \alpha(t) f(t) \ dt=0,$$
where $\alpha\colon [0,1]\rightarrow \mathbb{R}$ is continuous, positive and strictly monotone increasing. In this case
$$\int_0^1 \alpha(t) f(t) \ dt = F(1)\alpha(1)- F(0)\alpha(0)- \int_0^1 F(t) \ d\alpha,$$
where the last integral is a Riemann–Stieltjes integral.
Then we can prove the existence of maximum and Claim 1 and Claim 2 using analogous arguments. The uniqueness and nature of the point of maximum follows, that is, the unique point of maximum is
$$f_c= 1_{[0,c]}- 1_{(c,1]},$$
where $c$ is the only $c\in (0,1)$ satisfying
$$\int \alpha(t)f_c(t) \ dt =0.$$