Skip to content

Exclude docs.omniverse.nvidia.com from link checker#6535

Open
ooctipus wants to merge 1 commit into
isaac-sim:developfrom
ooctipus:zhengyuz/ci/exclude-omniverse-docs-linkcheck
Open

Exclude docs.omniverse.nvidia.com from link checker#6535
ooctipus wants to merge 1 commit into
isaac-sim:developfrom
ooctipus:zhengyuz/ci/exclude-omniverse-docs-linkcheck

Conversation

@ooctipus

Copy link
Copy Markdown
Collaborator

Description

The Check for Broken Links job is failing on develop and every open PR: docs.omniverse.nvidia.com now returns 403 Forbidden to the lychee crawler (85 links rejected in the latest develop run, e.g. https://github.com/isaac-sim/IsaacLab/actions/runs/29400148439). Reruns do not clear it — the domain is blocking the checker's requests, not individual pages.

This adds the domain to the existing crawl-blocker exclude list, matching the sibling entries (docs.isaacsim.omniverse.nvidia.com, openusd.org, etc.).

Type of change

  • Bug fix (CI)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file (not applicable — CI-only change)
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

🤖 Generated with Claude Code

The domain now returns 403 Forbidden to the lychee crawler, failing
the Check for Broken Links job on develop and every open PR. Exclude
it like the other known crawl blockers (e.g.
docs.isaacsim.omniverse.nvidia.com).
@greptile-apps

greptile-apps Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds docs.omniverse.nvidia.com to the lychee link-checker's --exclude list in the CI workflow, matching the pattern already used for docs.isaacsim.omniverse.nvidia.com and other domains that block automated crawlers with 403 responses.

  • Single-line addition to .github/workflows/check-links.yml, inserted between the two existing isaacsim.omniverse / download.isaacsim.omniverse entries in a logically consistent position.
  • No logic, configuration, or documentation is changed; the fix is purely additive to the exclusion list.

Confidence Score: 5/5

Safe to merge — the change is a single additive line to a CI exclusion list with no effect on source code, tests, or documentation.

The edit adds one regex pattern to the lychee --exclude list, following the exact same escaping and placement convention used by the existing sibling entries. It cannot break anything in the repo; at worst it silently skips a link that was previously checked, which is the intended outcome here given the domain's 403 response to the crawler.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/check-links.yml Adds docs.omniverse.nvidia.com to the lychee --exclude list; placement and regex escaping match existing sibling entries.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[CI: Check for Broken Links] --> B[lychee crawls *.md / *.rst / *.html]
    B --> C{URL in --exclude list?}
    C -- Yes --> D[Skip URL ✓]
    C -- No --> E[HTTP request]
    E --> F{Status Code}
    F -- 200-308, 429 --> G[Pass ✓]
    F -- 403, 5xx, timeout --> H[Fail ✗]
    D2[docs.omniverse.nvidia.com now returns 403 to crawler] -.->|added to exclude list| C
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[CI: Check for Broken Links] --> B[lychee crawls *.md / *.rst / *.html]
    B --> C{URL in --exclude list?}
    C -- Yes --> D[Skip URL ✓]
    C -- No --> E[HTTP request]
    E --> F{Status Code}
    F -- 200-308, 429 --> G[Pass ✓]
    F -- 403, 5xx, timeout --> H[Fail ✗]
    D2[docs.omniverse.nvidia.com now returns 403 to crawler] -.->|added to exclude list| C
Loading

Reviews (1): Last reviewed commit: "Exclude docs.omniverse.nvidia.com from l..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant