Trim away netframework targets in source-build#67355
Merged
Merged
Conversation
ghost
added
Community
Contributor
Author
mmitche
approved these changes
Mar 17, 2023
Member
|
Waiting for CI results before I approve. |
Contributor
Author
2 CI jobs are failing, but those seem to be failing in other PRs as well, i.e.: #67358 Failing integration jobs are running on Windows - my changes are affecting source-build on Linux only. |
333fred
previously approved these changes
Mar 20, 2023
Member
|
/azp run roslyn-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
Member
|
@NikolaMilosavljevic I wasn't concerned about it: the main |
333fred
approved these changes
Mar 20, 2023
Contributor
Author
Thank! I'll need your help merging the PR - I don't have permissions. |
Contributor
Author
|
Creating a backport request to |
Contributor
Author
|
/backport to release/dev17.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
This is part of the source-build work to enable trimming of net4* targets. Parent repos (
installerandsdk) have been updated, so the next step is to update dependencies, likeroslyn.Here's how this is consumed: dotnet/arcade#12785
Top-level tracking issue: dotnet/source-build#3014
This essentially just avoids building net4* TFMs when building Linux source build.
Fixes: #63746