Skip to content

Better trimming support + trimming fix#12785

Merged
mmitche merged 2 commits into
dotnet:mainfrom
mmitche:better-trimming-support-and-fix
Mar 6, 2023
Merged

Better trimming support + trimming fix#12785
mmitche merged 2 commits into
dotnet:mainfrom
mmitche:better-trimming-support-and-fix

Conversation

@mmitche

@mmitche mmitche commented Mar 3, 2023

Copy link
Copy Markdown
Member
  • Allow for trimming to be set in SourceBuild.props. This enables use in repo SB legs. Includes a default set which is all netcoreapps + netstandards.
  • Disable trimming for top level projects in Arcade, so that we don't accidentally skip things like publishing.

To double check:

@mmitche mmitche requested review from a team and NikolaMilosavljevic March 3, 2023 20:37
@mmitche

mmitche commented Mar 3, 2023

Copy link
Copy Markdown
Member Author

I made some tweaks to this, so I'm retesting locally.

@mmitche

mmitche commented Mar 3, 2023

Copy link
Copy Markdown
Member Author

One question I had was why Tools.proj looks like this:

https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Arcade.Sdk/tools/Tools.proj#L6-L13

I didn't disable trimming in this project yet. I think it might mean that the NuGetRepack pack will not get restored. Anyways, my main question is why this project explicitly sets a bunch of TFM properties.

@NikolaMilosavljevic

Copy link
Copy Markdown
Contributor

Just curious, where are these properties consumed? NoTargetFrameworkFiltering and DotNetTargetFrameworkFilter

@NikolaMilosavljevic

Copy link
Copy Markdown
Contributor
- Allow for trimming to be set in SourceBuild.props. This enables use in repo SB legs. Includes a default set which is all netcoreapps + netstandards.
- Disable trimming for top level projects in Arcade, so that we don't accidentally skip things like publishing.
@mmitche

mmitche commented Mar 6, 2023

Copy link
Copy Markdown
Member Author

@NikolaMilosavljevic Slight tweak here to the default TFM string (need re-approval). This did work in source build with it enabled to sdk +installer.

Comment thread src/Microsoft.DotNet.Arcade.Sdk/tools/SourceBuild/SourceBuildArcade.targets Outdated
@mmitche mmitche enabled auto-merge (squash) March 6, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants