opts: remove deprecated PortOpt, ConfigOpt, SecretOpt aliases #5953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
added
impact/changelog
impact/deprecation
area/go-sdk
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5953 +/- ##
=======================================
Coverage 59.12% 59.12%
=======================================
Files 355 355
Lines 29740 29740
=======================================
Hits 17583 17583
Misses 11182 11182
Partials 975 975 🚀 New features to boost your workflow:
|
These options were moved to opts/swarmopts in ad21055 and have no known external consumers. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
opts_remove_deprecated
branch
from
4ea907a to
bd03f11
Compare
Benehiko
approved these changes
Apr 11, 2025
Member
Author
|
@vvoland PTAL; I don't think there's any users of these outside of our own code, but let me know if you have any concerns removing the aliases |
vvoland
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options were moved to opts/swarmopts in ad21055 and have no known external consumers.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)