Skip to content

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Mar 8, 2025

opts: use stdlib errors and touch-up some errors

  • remove uses of github.com/pkg/errors
  • slight improvement on handling parsing errors
  • add some test-cases

opts: move swarm-specific options to a separate package

This prevents users of the CLI that don't implement swarm-related
features from depending on the swarm API types.

- Human readable description for the release notes

Go SDK: Deprecate `opts.PortOpt`, `opts.ConfigOpt` and `opts.SecretOpt`. These types were moved to the `opts/swarmopts` package.

- A picture of a cute animal (not mandatory but encouraged)

- remove uses of github.com/pkg/errors
- slight improvement on handling parsing errors
- add some test-cases

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.31%. Comparing base (2eec746) to head (d0d91bb).
Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5907      +/-   ##
==========================================
+ Coverage   59.26%   59.31%   +0.04%     
==========================================
  Files         357      357              
  Lines       29771    29782      +11     
==========================================
+ Hits        17645    17666      +21     
+ Misses      11153    11146       -7     
+ Partials      973      970       -3     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
This prevents users of the CLI that don't implement swarm-related
features from depending on the swarm API types.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added impact/deprecation status/2-code-review kind/refactor PR's that refactor, or clean-up code area/go-sdk Changes affecting the Go SDK labels Mar 8, 2025
@thaJeztah thaJeztah requested review from Benehiko and vvoland March 10, 2025 16:49
@thaJeztah thaJeztah added this to the 28.0.2 milestone Mar 10, 2025
@thaJeztah thaJeztah merged commit 64b5617 into docker:master Mar 10, 2025
107 checks passed
@thaJeztah thaJeztah deleted the opts_cleanup branch March 10, 2025 17:03
@thaJeztah thaJeztah self-assigned this May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/go-sdk Changes affecting the Go SDK impact/deprecation kind/refactor PR's that refactor, or clean-up code status/2-code-review

3 participants