Skip to content

Destinations V2 Remove Soft Reset #29805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Octavia The Approver (octavia-approvington) merged 9 commits into from
Aug 24, 2023
Merged

Destinations V2 Remove Soft Reset #29805

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d66e1f1
remove soft reset
jbfbell Aug 24, 2023
f0fd0d5
version bumps
jbfbell Aug 24, 2023
4c71de0
remove local variable
jbfbell Aug 24, 2023
6167f27
remove quoting
jbfbell Aug 24, 2023
6a1b6d4
Revert "version bumps"
jbfbell Aug 24, 2023
ab995fe
readme update
jbfbell Aug 24, 2023
c4b0981
Merge branch 'master' into joseph.bell/remove-soft-reset-for-migration
jbfbell Aug 24, 2023
fc695c2
snowflake changelog
jbfbell Aug 24, 2023
6365e53
use correct versions
jbfbell Aug 24, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove quoting
  • Loading branch information
@jbfbell
jbfbell committed Aug 24, 2023
commit 6167f27d9addf7630a7053e96ed02a9350101913
3 changes: 1 addition & 2 deletions .../io/airbyte/integrations/destination/snowflake/typing_deduping/SnowflakeV1V2Migrator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import java.util.LinkedHashMap;
import java.util.Optional;
import lombok.SneakyThrows;
import org.apache.commons.lang3.StringUtils;

public class SnowflakeV1V2Migrator extends BaseDestinationV1V2Migrator<SnowflakeTableDefinition> {

Expand Down Expand Up @@ -43,7 +42,7 @@ protected boolean doesAirbyteInternalNamespaceExist(final StreamConfig streamCon
WHERE schema_name = ?
AND catalog_name = ?;
""",
StringUtils.wrap(streamConfig.id().rawNamespace(), "\""),
streamConfig.id().rawNamespace(),
databaseName)
.isEmpty();
}
Expand Down