Skip to content

Destinations V2 Remove Soft Reset#29805

Merged
Octavia The Approver (octavia-approvington) merged 9 commits into
masterfrom
joseph.bell/remove-soft-reset-for-migration
Aug 24, 2023
Merged

Destinations V2 Remove Soft Reset#29805
Octavia The Approver (octavia-approvington) merged 9 commits into
masterfrom
joseph.bell/remove-soft-reset-for-migration

Conversation

@jbfbell
Copy link
Copy Markdown
Contributor

@jbfbell Joe Bell (jbfbell) commented Aug 24, 2023

Stop doing soft resets after a migration, this should happen anyway during the normal table preparation process because we'll detect that a table does not match the expected schema.

@jbfbell Joe Bell (jbfbell) marked this pull request as ready for review August 24, 2023 17:49
@jbfbell Joe Bell (jbfbell) requested a review from a team as a code owner August 24, 2023 17:49
@jbfbell Joe Bell (jbfbell) enabled auto-merge (squash) August 24, 2023 18:24
@github-actions
Copy link
Copy Markdown
Contributor

destination-snowflake test report (commit 4c71de0510) - ✅

⏲️ Total pipeline duration: 34mn30s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-snowflake docker image for platform linux/x86_64
Build airbyte/normalization-snowflake:dev
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test
@github-actions
Copy link
Copy Markdown
Contributor

destination-bigquery test report (commit 4c71de0510) - ❌

⏲️ Total pipeline duration: 34mn51s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-bigquery docker image for platform linux/x86_64
Build airbyte/normalization:dev
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test
@jbfbell
Copy link
Copy Markdown
Contributor Author

/approve-and-merge

@octavia-approvington
Copy link
Copy Markdown
Contributor

Trying to merge your PR using a bot?
Comment this on the PR:

/approve-and-merge reason="<STATE YOUR REASON HERE>"

Make sure you've reviewed the docs!

@jbfbell
Copy link
Copy Markdown
Contributor Author

/approve-and-merge reason="Destinations v2 tests already passing, added extra commit"

@octavia-approvington
Copy link
Copy Markdown
Contributor

This code is at peace with itself
imagine karate kid approving

@octavia-approvington Octavia The Approver (octavia-approvington) deleted the joseph.bell/remove-soft-reset-for-migration branch August 24, 2023 19:19
@github-actions
Copy link
Copy Markdown
Contributor

destination-snowflake test report (commit 6167f27d9a) - ✅

⏲️ Total pipeline duration: 35mn04s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-snowflake docker image for platform linux/x86_64
Build airbyte/normalization-snowflake:dev
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test
@github-actions
Copy link
Copy Markdown
Contributor

destination-bigquery test report (commit 6167f27d9a) - ❌

⏲️ Total pipeline duration: 33mn46s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-bigquery docker image for platform linux/x86_64
Build airbyte/normalization:dev
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test
@github-actions
Copy link
Copy Markdown
Contributor

destination-bigquery test report (commit 6425eea092) - ❌

⏲️ Total pipeline duration: 29mn21s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-bigquery docker image for platform linux/x86_64
Build airbyte/normalization:dev
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-bigquery/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-bigquery test
@github-actions
Copy link
Copy Markdown
Contributor

destination-snowflake test report (commit 6425eea092) - ❌

⏲️ Total pipeline duration: 03mn51s

Step Result
Java Connector Unit Tests
Build connector tar
Build destination-snowflake docker image for platform linux/x86_64
Build airbyte/normalization-snowflake:dev
Java Connector Integration Tests
Validate airbyte-integrations/connectors/destination-snowflake/metadata.yaml
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=destination-snowflake test
Harry Touloupas (harrytou) pushed a commit to KYVENetwork/airbyte that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants