Skip to content

translate Grid documents into Japanese #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 1, 2022

Conversation

rerorero
Copy link
Contributor

@rerorero rerorero commented Aug 9, 2022

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This PR translates Grid documents into Japanese.

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.
@CLAassistant
Copy link

CLAassistant commented Aug 9, 2022

CLA assistant check
All committers have signed the CLA.

@rerorero rerorero marked this pull request as ready for review August 9, 2022 16:56
@netlify
Copy link

netlify bot commented Aug 9, 2022

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit a0f8aca
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/62f290c483e16e0009b66f7d
😎 Deploy Preview https://deploy-preview-1112--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Aug 9, 2022

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
🔨 Latest commit 9d3291e
🔍 Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/6387ee792552f1000822cb6d
😎 Deploy Preview https://deploy-preview-1112--jovial-austin-42fe02.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rerorero
Copy link
Contributor Author

What's wrong? 🤔

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. I need to hold it for a while because I am rewriting parts of the Grid documentation, given that is it not easy to understand.

@rerorero
Copy link
Contributor Author

Okay, I will revisit it once you update the documents.

@diemol
Copy link
Member

diemol commented Nov 1, 2022

@rerorero Sorry, I forgot to reply. The docs have been updated already a while ago. Would you like to have a look again?

@rerorero
Copy link
Contributor Author

rerorero commented Nov 7, 2022

Thank you for letting me know, let me take a look again.

@rerorero rerorero marked this pull request as draft November 7, 2022 08:14
@rerorero rerorero marked this pull request as ready for review November 9, 2022 09:28
@rerorero rerorero requested a review from diemol November 9, 2022 09:28
@rerorero
Copy link
Contributor Author

rerorero commented Nov 9, 2022

@diemol I updated this branch based on the latest trunk. PTAL.

@diemol diemol requested a review from kzhirata November 9, 2022 11:09
@rerorero
Copy link
Contributor Author

@kzhirata Thank you for taking a look, I updated according to your comments.

@diemol diemol requested a review from kzhirata November 11, 2022 11:23
@kzhirata
Copy link
Contributor

@rerorero I've reviewed "website_and_docs/content/documentation/grid/getting_started.ja.md" and add some comments.

The rest of my review is below.

  • website_and_docs/content/documentation/grid/configuration/_index.ja.md
  • website_and_docs/content/documentation/grid/configuration/cli_options.ja.md
  • website_and_docs/content/documentation/grid/configuration/help.ja.md
  • website_and_docs/content/documentation/grid/configuration/toml_options.ja.md
Copy link
Contributor

@kzhirata kzhirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rerorero I’ve reviewed the below, and added some comments.

  • website_and_docs/content/documentation/grid/configuration/_index.ja.md
  • website_and_docs/content/documentation/grid/configuration/cli_options.ja.md
  • website_and_docs/content/documentation/grid/configuration/help.ja.md
  • website_and_docs/content/documentation/grid/configuration/toml_options.ja.md

Could you please check my comment?

@rerorero
Copy link
Contributor Author

Thanks, updated again.

Copy link
Contributor

@kzhirata kzhirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rerorero There are still some words to bold.

@rerorero
Copy link
Contributor Author

oops, sorry for this bold nightmare... updated again.

Copy link
Contributor

@kzhirata kzhirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rerorero Last 3 comments.
Could you check my comment, please?

@rerorero
Copy link
Contributor Author

Sorry for late, updated again.

Copy link
Contributor

@kzhirata kzhirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rerorero There are two points I pointed out last time, so could you please fix them?

@rerorero
Copy link
Contributor Author

rerorero commented Dec 1, 2022

Fixed again.

Copy link
Contributor

@kzhirata kzhirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kzhirata
Copy link
Contributor

kzhirata commented Dec 1, 2022

Thank you @rerorero !

@kzhirata kzhirata merged commit 997a48e into SeleniumHQ:trunk Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants