-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
translate Grid documents into Japanese #1112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for jovial-austin-42fe02 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for jovial-austin-42fe02 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
What's wrong? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR. I need to hold it for a while because I am rewriting parts of the Grid documentation, given that is it not easy to understand.
Okay, I will revisit it once you update the documents. |
@rerorero Sorry, I forgot to reply. The docs have been updated already a while ago. Would you like to have a look again? |
Thank you for letting me know, let me take a look again. |
@diemol I updated this branch based on the latest trunk. PTAL. |
@kzhirata Thank you for taking a look, I updated according to your comments. |
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
@rerorero I've reviewed "website_and_docs/content/documentation/grid/getting_started.ja.md" and add some comments. The rest of my review is below.
|
website_and_docs/content/documentation/grid/configuration/cli_options.ja.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rerorero I’ve reviewed the below, and added some comments.
- website_and_docs/content/documentation/grid/configuration/_index.ja.md
- website_and_docs/content/documentation/grid/configuration/cli_options.ja.md
- website_and_docs/content/documentation/grid/configuration/help.ja.md
- website_and_docs/content/documentation/grid/configuration/toml_options.ja.md
Could you please check my comment?
Thanks, updated again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rerorero There are still some words to bold.
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
oops, sorry for this bold nightmare... updated again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rerorero Last 3 comments.
Could you check my comment, please?
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
Sorry for late, updated again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rerorero There are two points I pointed out last time, so could you please fix them?
website_and_docs/content/documentation/grid/getting_started.ja.md
Outdated
Show resolved
Hide resolved
Fixed again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @rerorero ! |
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This PR translates Grid documents into Japanese.
Motivation and Context
Types of changes
Checklist