this is a simple question...
Does this method can be refactored?
def sum
total = 0
[1,2,3,4].each do |num|
total += num
end
total
end
thanks for your help!
-
2Questions where you're asking for suggestions to refactor and/or improve existing code are better suited for the new code review stackexchange site than stackoverflow. Consider asking similar questions there in the future. Thank you.sepp2k– sepp2k2011-02-27 18:58:21 +00:00Commented Feb 27, 2011 at 18:58
Add a comment
|
4 Answers
You can use this:
[1,2,3,4].inject(0, :+) # => 10
answered Feb 27, 2011 at 18:54
3 Comments
Vasiliy Ermolovich
[].inject(:+) will return nil. What's wrong with that? Why do we need 0 instead of nil?
sepp2k
a) Because it's what the OP code does, b) because the sum of the empty set is 0 according to any definition I've ever read and c) you can't do arithmetic on nil so a return value of nil just isn't useful.
sepp2k
To elaborate on point c: I would expect something like
balance - sum(items_bought.map(&:price)) to evaluate to balance if items_bought is empty, not raise an exception.[1,2,3,4].inject { |total,num| total= total+num }
OR as per suggestion below it should be
[1,2,3,4].inject(0) { |total,num| total+num }
>> [1, 2, 3, 4].inject(0) { |acc, x| acc + x }
=> 10
Or simply:
>> [1, 2, 3, 4].inject(0, :+)
=> 10
Comments
Same as the following How to sum array of numbers in Ruby?
answered Feb 27, 2011 at 19:50
