node js mongoose delete a from an id in document array

Question

I've two collection of reference both collection together. One of the collection is user and the other collection is project.

So, a user can add project to the projects collection, then one of the user type called supervisor can add staff to the project and the project id saved to the user collection which referred to staff document on the project collection.

So actually i need to do when admin deletes a supervisor from the user collection it deletes all the projects created by supervisor users's id that equal to addedBy documents which deleted from the users collection.

So my problems is when i do this process i need to delete all the project id is equal to the users collection projectId. it's an array and I tried to do this to many times but i couldn't find a solution. I'll provide all of the source code. That i created for this project.

Users collection

const userSchema = new Schema({


firstName: {
        type: String
    },
    lastName: {
        type: String
    },
    email: {
        type: String
    },
    username: {
        type: String
    },
    password: {
        type: String
    },
    usertype: {
        type: Schema.ObjectId,
        ref: 'usertypes'
    },
    projectId: [{
        type: Schema.ObjectId,
        ref: 'projects'
    }]
});

Project collection

const proSchema = new Schema({
projectName: {


    type: String
    },
    description: {
        type: String
    },
    addedBy: {
        type: Schema.ObjectId,
        ref: 'users'
    },
    staff: [{
        type: Schema.ObjectId,
        ref: 'users'
    }]
});

Here is the query that i tried to do the process that i mentioned in above

Users
.findByIdAndRemove({
    _id: req.params.id
})
.then(function(){
    Projects
    .remove({
        userId: req.params.id
    })
    .then(function(err, project){
        if(err) throw err;
        console.log(project.id)
        Users
        .update({}, { 
            $pull: {
                projectId: project.id
            }
        }, function(){
            res.json({
                success: true,
                message: "Deleted"
            });
        });
    });
});

Answer 1

I think the problems are

(1) Model.findByIdAndRemove only expects the ID (not the condition) i.e. Users.findByIdAndRemove(req.params.id) instead of Users.findByIdAndRemove({ _id: req.params.id })

(2) Model.remove's callback does not have a second argument in Projects.remove({ userId: req.params.id }).then(function (err, project) {. As well, you don't have a userId field in your ProjectSchema.

I would do

// delete user
Users.findByIdAndRemove(req.params.id, function (err, user) {
    console.log('deleting user', user);
    if (err)
        throw err;
    // delete user's projects
    Projects.remove({ addedBy: user._id }, function (err) {
        console.log('deleting projects');
        if (err)
            throw err;
        // delete project references
        Users.update({}, { $pull: { projectId: { $in: user.projectId }}}, function (err) {
            console.log('deleting project references');
            if (err)
                throw err;
            res.json({ success: true, message: "Deleted" });
        });
    });
});

(3) user.projectId is an array of ObjectIDs, so you need to use $in (see first example).

Aside: projects is a better name than projectId. The latter is ambiguous because a user has multiple projects not projectIds.

Answer 2

User.findByIdAndUpdate(req.params.idRec, 
{ $pull: { comments: { _id: comm._id } } }, 
 function (err, doc) {
                    if (!err) {
                        res.status(200).send()
                    } else {
                        res.render('error', { error: err })
                    }
                })