String array causing app to stop

Question

Here code begins of one class named as Homepage.java -

This is initial declarations -

int j=0,i=0;
String[] fetch_name,fetch_num;

Then following block is used to fetch phonebook contacts -

Cursor phones1 = getContentResolver().query(ContactsContract.CommonDataKinds.Phone.CONTENT_URI, null,null,null, null );
    while(phones1.moveToNext())
    {
        j=j+1;
    }
    fetch_name = new String[j];
    fetch_num = new String[j];
    while(phones1.moveToNext())
    {
        fetch_name[i]= phones1.getString(phones1.getColumnIndex(ContactsContract.CommonDataKinds.Phone.DISPLAY_NAME));
        fetch_num[i] = phones1.getString(phones1.getColumnIndex(ContactsContract.CommonDataKinds.Phone.NUMBER));
        i =i + 1;
    }
    phones1.close();

Now following are methods returning String Array & integer

public String[] getfname()
{
    return(fetch_name);
}
public  String[] getfnum()
{
    return(fetch_num);
}
public  int getj()
{
    return(j);
}

Now in second class named as Contactss.java code is as follow -

public class Contactss extends android.support.v4.app.Fragment 
{
Homepage hp = new Homepage();
Chatss cs = new Chatss();
int k = hp.getj();
public View onCreateView(LayoutInflater inflater,
        @Nullable ViewGroup container, @Nullable Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    View v = inflater.inflate(R.layout.fragment_contactss, container, false);
    loadd();
    return v;
}
public void loadd() {
    // TODO Auto-generated method stub
    String xyz  []= hp.getfnum();
    Toast.makeText(getActivity(), "jhbh" + xyz.length, Toast.LENGTH_LONG).show();
}


}

The above code causing app to stop, no idea why my app is going to stop. Please help.

I think MByD has identified the issue, but if he hasn't the please add the error log from LogCat — PPartisan
– PPartisan, Commented Sep 21, 2015 at 16:40

MByD · Accepted Answer · 2015-09-21 16:39:33Z

3

You go through the entire results here:

while(phones1.moveToNext())
{
    j=j+1;
}

But never reset to the first element again, so you have no more elements in the Cursor, and you set nothing in the arrays. You can either move to the first when you are done counting using Cursor#moveToFirst(), or even better, count using the Cursor#getcount() method.

As a side note, please add logcat log next time you have a problem, it will make yours (and our) work much easier

answered Sep 21, 2015 at 16:39

MByD

138k30 gold badges269 silver badges278 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

MD Farog Over a year ago

Sorry, log cat is not available, coming to the solution, problem still exist and following statement occuring exception- Toast.makeText(getActivity(), "jhbh" + xyz.length, Toast.LENGTH_LONG).show(); When i concatinate "xyz.length", exception occur when i don't no exception occurs

MByD Over a year ago

maybe you should check if xyz is null

MByD Over a year ago

if (xyz == null) Toast.makeText(getActivity(), "oh no, xyz is null", Toast.LENGTH_LONG).show();

Collectives™ on Stack Overflow

String array causing app to stop

1 Answer 1

3 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Related