String arrays does not match

Question

My program displays an array of questions (question one-by-one). After I write an answer, an alert message should tell me whether my answer is right or wrong. The problem is that, even if I write the right answer the alert message displays a "false" message.

final String questions[] = {"Who's Tom?", "Who's Luca?", "Who's Flavie?"}
final String answers[] = {"American", "Italian", "French"}

// display question
answer_question.setOnClickListener(new View.OnClickListener() {
    int CurrentQuestionIndex = 0;

    public void onClick(View v) {
        ask_question.setText(question[(CurrentQuestionIndex++) % (questions.length)]);

        // discuss question versus answer
        EditText answer = (EditText) findViewById(R.id.tvReponseF);

        if (answer.equals(answers[CurrentQuestionIndex])) {
            alertMessageRight();
        } else {
            alertMessageFalse();
        }
    } 
});

Posts your answers array.

Jorge E. Hernández
– Jorge E. Hernández

2016-07-08 19:03:02 +00:00
Commented Jul 8, 2016 at 19:03 — Jorge E. Hernández
– Jorge E. Hernández, Commented Jul 8, 2016 at 19:03

Tom · Accepted Answer · 2016-07-08 20:30:55Z

6

The problem is that you're comparing an EditText object with a String field. You must compare String with String instead.

Here's how to do it:

String answer = ((EditText) findViewById(R.id.tvReponseF)).getText().toString();

if(answer.equals(answers[CurrentQuestionIndex]))
{
     ...

edited Jul 8, 2016 at 20:30

Tom

17.7k17 gold badges48 silver badges55 bronze badges

answered Jul 8, 2016 at 19:03

Carlo

1,5791 gold badge11 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Vucko Over a year ago

that's not all, that's just a minor issue. He's increasing the index counter at the wrong place, check my answer, I covered that also.

Vucko · Accepted Answer · 2016-07-08 19:06:39Z

The problem is that you're increasing the index before actually checking if the answer's correct:

ask_question.setText(question[(CurrentQuestionIndex++) % (questions.length)]);

So the if the question index is 0, you'll get a question 0, then the question index will become 1 because of the ++ operator and you'll be reading the answer 1 instead of 0. I hope you understand this. What you need to do is remove the ++ from here and place it here:

if(answer.getText().toString().equals(answers[(CurrentQuestionIndex++) % (questions.length)]))

Because at this point, you'll read the proper answer and move on to the next index.

EDIT:

This was your biggest problem. Also you need to compare the answer.getText().toString() as the other guys already noticed.

Jorge E. Hernández · Accepted Answer · 2016-07-08 19:10:05Z

You need to get the text from the EditText object. You are comparing an EditText object with a String.

So, your complete code should look like this:

final String questions[] = {"Who's Tom?", "Who's Luca?", "Who's Flavie?"}
final String answers[] = {"American", "Italian", "French"}

// display question
answer_question.setOnClickListener(new View.OnClickListener() {
int CurrentQuestionIndex = 0;
    public void onClick(View v) {

        ask_question.setText(question[(CurrentQuestionIndex++) % (questions.length)]);
        // discuss question versus answer
        EditText editText = (EditText) findViewById(R.id.tvReponseF);
        if(editText.getText().toString().equals(answers[CurrentQuestionIndex]))  
        {
            alertMessageRight();
        } else {
            alertMessageFalse();
        }
    } 
 });

Zoe - Save the data dump · Accepted Answer · 2016-07-08 19:03:06Z

2

Try this:

EditText et;//initialize first!!
et.getText().toString().equals(....);

answered Jul 8, 2016 at 19:03

Zoe - Save the data dump

28.4k22 gold badges130 silver badges163 bronze badges

Comments

Rohan Sood · Accepted Answer · 2016-07-08 19:07:31Z

2

 EditText answer = (EditText) findViewById(R.id.tvReponseF);

 if(answer.getText().toString().toLowerCase().equals(answers[CurrentQuestionIndex].toLowerCase()))  
{
    alertMessageRight();
} else {
    alertMessageFalse();
}

 }

I added the toLowerCase() just make the problem case insensitive.

answered Jul 8, 2016 at 19:07

Rohan Sood

1782 silver badges14 bronze badges

Collectives™ on Stack Overflow

String arrays does not match

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

Comments

Comments

Comments

Related