Fetching data from MySQL table, using PHP

Question

$get="SELECT dial_prod_total FROM dial_product WHERE dial_prod_id='$dpname'";
$idgen=mysql_query($get) or die(mysql_error());
$total=$idgen+$dpqty;
$dpbuy="UPDATE dial_product set dial_prod_total= '$total'".
       "WHERE dial_prod_id='$dpname'";
$result1=mysql_query($dpbuy) or die(mysql_error());

I want to get the data in the column dial_prod_total using the ID stored in $dpname and then update the value and store in the same column. The value is replaced in the column but it's not the correct value. What is the mistake I have made? Please help me.

$idgen isn't the value of the query...it's like a result object. You have to get the actual number with mysql_fetch_row or something — Ken
– Ken, Commented Mar 22, 2013 at 18:44
Please, don't use mysql_* functions in new code. They are no longer maintained and are officially deprecated. See the red box? Learn about prepared statements instead, and use PDO or MySQLi - this article will help you decide which. — Kermit
– Kermit, Commented Mar 22, 2013 at 18:55

Explosion Pills · Accepted Answer · 2013-03-22 18:47:10Z

1

Why don't you just do

UPDATE dial_product SET dial_prod_total = dial_prod_total + $dpqty
WHERE dial_prod_id = '$dpname'

Your code is vulnerable to injection. You should use properly parameterized queries with PDO or mysqli.

answered Mar 22, 2013 at 18:47

Explosion Pills

192k56 gold badges341 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

praveenrsmart Over a year ago

it shows error "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'dial_prod_id = 'prod6'' at line 1"

Explosion Pills Over a year ago

@praveenrsmart dpqty is apparently an empty string

praveenrsmart Over a year ago

no its not. bec i am using it in two places.. when inserting into the first table i am getting the value, while updating alone i am getting problem

Explosion Pills Over a year ago

@praveenrsmart can you print out the whole query before you run it and show it to me?

praveenrsmart Over a year ago

$dpbuy="INSERT INTO dail_prod_buy(dial_prod_id,dial_dob,dail_prod_arrived,dial_buy_bill,dial_buy_cost)". "VALUES('$dpname','$dpdor','$dpcost','$dpqty','$dpdetail')"; $result=mysql_query($dpbuy) or die(mysql_error());

|

Techie · Accepted Answer · 2013-03-22 18:50:54Z

0

You query can be rebuild as below.

"UPDATE dial_product set dial_prod_total = dial_prod_total + ".$total." WHERE dial_prod_id = ".$dpname." ";

answered Mar 22, 2013 at 18:50

Techie

45.2k45 gold badges164 silver badges248 bronze badges

Collectives™ on Stack Overflow

Fetching data from MySQL table, using PHP

2 Answers 2

8 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

8 Comments

Comments

Related