Fetch information from mysql db using php

Question

Updated script with proper field names. Why isnt this working?

<?php
$con = mysql_connect("localhost","root","pass");
if (!$con)
{
    die('Could not connect: ' . mysql_error());
}

mysql_select_db("bookorama", $con);

$sql="SELECT * FROM customers"; 
$result = mysql_query($sql);     // You actually have to execute the $sql with mysql_query();

echo "<table>";  //start the table

while($row = mysql_fetch_array($result, MYSQL_ASSOC))  //Loop through the results
{
    //echo each row of the table
    echo "<tr>                              
            <td>$row['customerID']</td>
             <td>$row['name']</td>
            <td>$row['Aaddress']</td>
            <td>$row['city']</td>
          </tr>";
} 

echo '</table>';   //close out the table

?>

you don't actully run your query $sql, or retrieve the results from it. see the manual for: mysql_query(),mysql_fetch_assoc() — user557846
– user557846, Commented Mar 1, 2011 at 1:44

jondavidjohn · Accepted Answer · 2011-03-01 14:00:51Z

2

<?php
$con = mysql_connect("localhost","root","pass");
if (!$con)
{
    die('Could not connect: ' . mysql_error());
}

mysql_select_db("bookorama", $con);

$sql="SELECT * FROM customers"; 
$result = mysql_query($sql);     // You actually have to execute the $sql with mysql_query();

echo "<table>";  //start the table

while($row = mysql_fetch_array($result, MYSQL_ASSOC))  //Loop through the results
{
    //echo each row of the table
    echo "<tr>";                              
    echo "<td>$row['CustomerID']</td>";
    echo "<td>$row['address']</td>";
    echo "<td>$row['city']</td>";
    echo "</tr>";
} 

echo '</table>';   //close out the table

?>

edited Mar 1, 2011 at 14:00

answered Mar 1, 2011 at 1:45

jondavidjohn

62.5k21 gold badges120 silver badges159 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Jshee Over a year ago

this gives me an error: Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING on line 19

Jshee Over a year ago

This still gives the error: Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING on line 19

Jshee Over a year ago

Nvm, I fixed it myself. Thanks again @jondavidjohn

Marcin · Accepted Answer · 2011-03-01 01:44:51Z

2

You can mysql_fetch_array or mysql_fetch_assoc to retriever the rows from you query.

For example using mysql_fetch_array:

$result = mysql_query($sql);
echo "<table><tbody>";
while ($row = mysql_fetch_array($result, MYSQL_NUM)) {
    echo "<tr><td>".$row[0] . "</td><td>" . $row[1] . "</td></tr>";  
}
echo "</tbody></table>"

answered Mar 1, 2011 at 1:44

Marcin

241k16 gold badges315 silver badges368 bronze badges

Comments

alex · Accepted Answer · 2011-03-01 01:43:33Z

0

You need to run the query and loop through the results.

You are better off learning from day one about PDO.

And also don't interpolate directly from any user submitted variables (that includes $_POST).

answered Mar 1, 2011 at 1:43

alex

492k205 gold badges890 silver badges991 bronze badges

Comments

codercake · Accepted Answer · 2011-03-01 04:50:47Z

0

Pretty sure you need to do this when embedding anything more complex than scalars inside double quotes

 echo "<tr>                              
        <td>{$row['CustomerID']}</td>
        <td>{$row['address']}</td>
        <td>{$row['city']}</td>
      </tr>";

So whenever you have a more complex var name than "test $var" in quotes, wrap with {} - and even then, it's good practice to wrap scalars too like "test {$var}"

answered Mar 1, 2011 at 4:50

codercake

1,0177 silver badges6 bronze badges

Collectives™ on Stack Overflow

Fetch information from mysql db using php

4 Answers 4

3 Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Related