Code Optimization in the switch cases .NET

Question

I have written a piece of lousy code in C#.NET and i want to optimize it.

All i can think of at the moment is to separate the common portions into a separate method.

Code :

if(condition1)
{     
   switch(condition)
       case 'A' :   //Some code
        break;
       case 'B' :   //Some code
        break;
       case 'C' :   //Some code
        break;
}

else if(condition2)
{     
   switch(condition)
       case 'a' :   //Some code
        break;
       case 'B' :   //Some code
        break;
       case 'C' :   //Some code
        break;
}

Note that the case statements conditions for case 'B' and case 'C' are common.

Any help on improving the code is deeply appreciated.

Answer 1

Why don't you stack the case statements if their code block should do same code

Like this

case 'B' :
case 'C' :
{
//Do Some Code
}
break;

Answer 2

case "a":
case "A":
    if ( condition1) {
        ...
    }
    else if { condition2}
        ...
    }
    break;

Answer 3

All you can do is putting the common code together and check the additional condition there.

switch(condition)
{
   case 'A':
     if(condition1) //do something
     else //do something
     break;

  case 'a':
   same as above

  case 'B':
    break;

  case 'C':
    break;
}

Answer 4

I think even if you optimize that piece of code, it would still be very fragile and hard to maintain. I would suggest to try to refactor it using strategy-pattern for example (if it's possible of course).

You would benefit a lot, cause you isolate each routine and do it OOP-way, making it easier to change and maintain in future.