Skip to content

fix xmasked_view with xfunction#2501

Open
gouarin wants to merge 3 commits into
xtensor-stack:masterfrom
gouarin:fix-masked-view
Open

fix xmasked_view with xfunction#2501
gouarin wants to merge 3 commits into
xtensor-stack:masterfrom
gouarin:fix-masked-view

Conversation

@gouarin

@gouarin gouarin commented Mar 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Checklist

  • The title and commit message(s) are descriptive.
  • Small commits made to fix your PR have been squashed to avoid history pollution.
  • Tests have been added for new features or bug fixes.
  • API of new functions and classes are documented.

Description
@tdegeus

tdegeus commented Apr 26, 2022

Copy link
Copy Markdown
Member

@gouarin I'm not a big expert here so I cannot estimate what it takes to fix this. A question though: Should be aim to include this in the next release.
@gouarin

gouarin commented Apr 26, 2022

Copy link
Copy Markdown
Member Author

I fixed the first issue but a new one appears. I had a discussion with @JohanMabille about that and it's not so easy to fix it.
We will take time together to find a solution after his vacation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@gouarin @tdegeus