Skip to content

Calculate basic alignment score for word pairs from the sentence_score#316

Draft
pmachapman wants to merge 1 commit into
mainfrom
save_alignment_scores
Draft

Calculate basic alignment score for word pairs from the sentence_score#316
pmachapman wants to merge 1 commit into
mainfrom
save_alignment_scores

Conversation

@pmachapman

@pmachapman pmachapman commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

This PR takes the average of the forward and reverse sentence_score from eflomal, places it between 0 and 1.0, and saves it for each word pair score.

Not accurate at all as a per-word pair score, but without using a different aligner than eflomal, I am not too sure how else to get an accurate word alignment score.


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit June 18, 2026 03:11

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's too bad that they don't expose the per-word scores - I didn't realize that, sorry. I leave it to Damien whether he's comfortable with this workaround until eflomal is properly integrated.

@Enkidu93 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

@ddaspit ddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hold off on persisting the alignment scores until we have a proper implementation. This is just a nice to have feature anyway.

@ddaspit reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman pmachapman marked this pull request as draft June 28, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants