Skip to content

workflows: Fix uv call#1798

Open
jku wants to merge 1 commit into
sigstore:mainfrom
jku:fix-pin-requirements
Open

workflows: Fix uv call#1798
jku wants to merge 1 commit into
sigstore:mainfrom
jku:fix-pin-requirements

Conversation

@jku

@jku jku commented Jun 3, 2026

Copy link
Copy Markdown
Member

No description provided.

woodruffw
woodruffw previously approved these changes Jun 3, 2026
Comment thread .github/workflows/pin-requirements.yml Outdated
@woodruffw

Copy link
Copy Markdown
Member

Oops, didn't mean to self-improve that suggestion.

(I switch it to uv tool install since uv pip install will fail in this case, without a venv. uv tool install is the right way to install an isolated tool.)

@jku

jku commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

Oh I see: I guess then we can also use uvx directly to avoid the install step

I think we managed to get to a state where neither one can approve... I'll force-push a fix

@jku jku force-pushed the fix-pin-requirements branch from c62236c to c561c42 Compare June 4, 2026 07:27
@jku

jku commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

uv tool install is the right way to install an isolated tool

I am not sure I actually agree with this for CI: there is no way to use pinned versions with uv tool AFAICT. Longer term I think we should aim to have all our build/dev tools listed in uv.lock, and should use those versions -- at least then we'd get a benefit from the busy work of maintaining a lock file

@jku jku marked this pull request as draft June 11, 2026 16:36
@jku

jku commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

actually uvx pip-compile does not work because that's not the package name. Will fix

Use uvx to run pip-compile

Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
@jku jku force-pushed the fix-pin-requirements branch from c561c42 to 00cbb13 Compare June 11, 2026 16:42
@jku jku marked this pull request as ready for review June 11, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants