fix: Assertion failure on dyn trait in closure#22790
Open
Wilfred wants to merge 1 commit into
Open
Conversation
Similarly to rust-lang#22677, it's possible to get an assertion failure in HIR inference after error recovery. The best repro I've found is actually the sample code from Rust issue 157951. I do think it's a legitimate fix, I've seen two real users hit this assertion. Give up if we don't have a closure kind in DeferredCallResolution::resolve(), and add a regression test that previously asserted. AI disclosure: Implemented with some help by GPT-5.5.
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
self-requested a review
July 14, 2026 22:54
Contributor
|
Unlike the previous PR, this code was not changed in rustc and yet does not ICE. I want to understand why before removing the assertion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to #22677, it's possible to get an assertion failure in HIR inference after error recovery.
The best repro I've found is actually the sample code from Rust issue
157951. I do think it's a legitimate fix, I've seen two real users hit this assertion.
Give up if we don't have a closure kind in
DeferredCallResolution::resolve(), and add a regression test that previously asserted.
AI disclosure: Implemented with some help by GPT-5.5.