Skip to content

fix: add arm64 capability to tests#82025

Open
jan-law wants to merge 1 commit into
openshift:mainfrom
jan-law:grc-arm64
Open

fix: add arm64 capability to tests#82025
jan-law wants to merge 1 commit into
openshift:mainfrom
jan-law:grc-arm64

Conversation

@jan-law

@jan-law jan-law commented Jul 16, 2026

Copy link
Copy Markdown

Follow up to #63142

The images appear to build successfully, but the e2e tests were placed on a cluster without arm64:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/stolostron_governance-policy-framework/1064/pull-ci-stolostron-governance-policy-framework-release-2.17-test-e2e-grc-framework/2077493608629407744

  1. Followed https://docs.ci.openshift.org/how-tos/capabilities/#configuration
  2. Ran make jobs

Summary by CodeRabbit

Updates Stolostron Governance Policy Framework CI configuration in ci-operator/config/stolostron/governance-policy-framework so the test-e2e-grc-framework e2e job is constrained to clusters that advertise the arm64 capability. This change is applied across the main and supported release YAMLs (e.g., 2.11–2.17 and 5.0), ensuring e2e runs on arm64-capable clusters instead of non-arm64 ones.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 458dcaac-a8dc-4d50-bda1-20e9e7069619

📥 Commits

Reviewing files that changed from the base of the PR and between aed0be4 and 1ecb044.

⛔ Files ignored due to path filters (9)
  • ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-main-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.11-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.12-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.13-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.14-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.15-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.16-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.17-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (9)
  • ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-main.yaml
  • ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.11.yaml
  • ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.12.yaml
  • ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.13.yaml
  • ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.14.yaml
  • ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.15.yaml
  • ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.16.yaml
  • ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-2.17.yaml
  • ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-release-5.0.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/stolostron/governance-policy-framework/stolostron-governance-policy-framework-main.yaml

Walkthrough

Governance policy framework CI configurations now declare an arm64 capability requirement for the test-e2e-grc-framework test entry across main and release pipelines.

Changes

Governance policy framework ARM64 configuration

Layer / File(s) Summary
Add ARM64 test capability declarations
ci-operator/config/stolostron/governance-policy-framework/*
The main configuration and release 2.11–2.17 and 5.0 configurations add arm64 to the test-e2e-grc-framework capabilities list.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: gparvin, yiraechristinekim

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding arm64 capability to test CI jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only ci-operator YAML/job configs changed; no Ginkgo test titles were added or modified, and existing job names are static.
Test Structure And Quality ✅ Passed PR only adds arm64 capability labels to CI YAML/job configs; no Ginkgo test code or assertions changed.
Microshift Test Compatibility ✅ Passed Diff only adds arm64 CI capabilities/labels in generated YAML; no new or changed Ginkgo tests or API usage to vet for MicroShift.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: PR only updates ci-operator YAML to add arm64 capabilities; no Ginkgo test code changed, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator config/job YAMLs changed; no deployment manifests, operators, or controllers were modified, so the topology check doesn't apply.
Ote Binary Stdout Contract ✅ Passed PR only edits ci-operator/job YAML to add arm64 capabilities; no OTE binary, test setup, or stdout-writing code changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Diff only updates ci-operator YAML to add arm64 capability; no new Ginkgo tests or IP/network logic changed.
No-Weak-Crypto ✅ Passed The PR only adds arm64 CI capabilities in YAML; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons were introduced.
Container-Privileges ✅ Passed The touched YAMLs only add capabilities: [arm64]; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings appear in the changed files.
No-Sensitive-Data-In-Logs ✅ Passed Diff only adds arm64 capabilities/labels; added lines contain no passwords, tokens, keys, PII, or other sensitive data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jan-law

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2026
@jan-law

jan-law commented Jul 16, 2026

Copy link
Copy Markdown
Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: Janelle Law <jalaw@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jan-law: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-stolostron-governance-policy-framework-release-2.16-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-2.13-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-2.17-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-2.11-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-5.0-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-2.12-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-2.15-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-main-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
pull-ci-stolostron-governance-policy-framework-release-2.14-test-e2e-grc-framework stolostron/governance-policy-framework presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jan-law

jan-law commented Jul 16, 2026

Copy link
Copy Markdown
Author

/pj-rehearse

@jan-law

jan-law commented Jul 16, 2026

Copy link
Copy Markdown
Author

/pj-rehearse abort
/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jan-law: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@jan-law: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/stolostron/governance-policy-framework/release-2.14/test-e2e-grc-framework 1ecb044 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.14-test-e2e-grc-framework
ci/rehearse/stolostron/governance-policy-framework/release-2.11/test-e2e-grc-framework 1ecb044 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.11-test-e2e-grc-framework
ci/rehearse/stolostron/governance-policy-framework/release-2.16/test-e2e-grc-framework 1ecb044 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.16-test-e2e-grc-framework
ci/rehearse/stolostron/governance-policy-framework/release-2.17/test-e2e-grc-framework 1ecb044 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-2.17-test-e2e-grc-framework
ci/rehearse/stolostron/governance-policy-framework/release-5.0/test-e2e-grc-framework 1ecb044 link unknown /pj-rehearse pull-ci-stolostron-governance-policy-framework-release-5.0-test-e2e-grc-framework

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

1 participant