Backport of Check websocket upgrade headers correctly with multiple values into release/2.0.x#28235
Merged
allisonlarson merged 2 commits intoJul 10, 2026
Conversation
43d5831 to
d1a32fa
Compare
allisonlarson
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #28234 to be assessed for backporting due to the inclusion of the label backport/2.0.x.
The below text is copied from the body of the original PR.
Description
Some browsers will add additional
Connectionheaders, (keep-alive), and send them as a comma separated list, which won't parse correctly by just usingreq.Header.Get. Updates the header check to use gorilla/websockets logic to ensure we can support these headers, and add tests to prevent regressions.Testing & Reproduction steps
Added test to highlight the problem, even though it ends up testing the gorilla/websocket package. It's more to highlight that we should be able to handle these types of headers.
Links
Fixes #28216
Contributor Checklist
changelog entry using the
make clcommand.ensure regressions will be caught.
and job configuration, please update the Nomad product documentation, which is stored in the
web-unified-docsrepo. Refer to theweb-unified-docscontributor guide for docs guidelines.Please also consider whether the change requires notes within the upgrade
guide. If you would like help with the docs, tag the
nomad-docsteam in this PR.and followed the AI usage guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Overview of commits
f30ea73
505c44a