Highlight matched text in editor drop-down list#3938
Draft
vogella wants to merge 1 commit into
Draft
Conversation
The chevron drop-down on editor stacks supports filtering, but matched characters were rendered without emphasis. Switch BasicPartList to a StyledCellLabelProvider that bolds the matched substring using the same StyledStringHighlighter the Quick Switch Editor (Ctrl+E) dialog uses. The dirty-prefix asterisk is excluded from highlighting so only the filename portion gets bolded. Issue: eclipse-platform#194
Member
|
Screenshots? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chevron drop-down on editor stacks supports filtering but rendered matched characters in plain weight, so it was hard to see why a row qualified. This change switches
BasicPartListto aStyledCellLabelProviderthat bolds matched substrings using the sameStyledStringHighlighterthe Quick Switch Editor (Ctrl+E) dialog already uses, giving both lists a consistent look. The dirty-prefix asterisk is excluded from highlighting so only the filename portion is bolded.Closes #194