Skip to content

fix: ButtonGroup overflow detection for labels without word break#10186

Draft
yihuiliao wants to merge 2 commits into
mainfrom
fix-buttongroup-overflow
Draft

fix: ButtonGroup overflow detection for labels without word break#10186
yihuiliao wants to merge 2 commits into
mainfrom
fix-buttongroup-overflow

Conversation

@yihuiliao

@yihuiliao yihuiliao commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #5679

it's late in the night...i will fill this out tmr

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:
@rspbot

rspbot commented Jun 11, 2026

Copy link
Copy Markdown

Build successful! 🎉
snowystinger
snowystinger reviewed Jun 11, 2026
View reviewed changes

@snowystinger snowystinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the bug was originally reported in s1/v3. I assume it's the same issue in both places?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ButtonGroup S2

3 participants

@yihuiliao @rspbot @snowystinger