feat: Add Step Local Memory (#134), Generation ID Protection (#128), and While Loop Breakpoint Support (#166)#222
Open
jagannalla wants to merge 2 commits into
Open
Conversation
This was referenced Jun 14, 2026
…data protection (Netflix#128) - Added transient, step-instance-scoped local memory with 64KB limit and automated cleanup. - Added generation_id database column to maestro_step_instance and enforced checks on UPSERT/UPDATE to prevent stale worker writes. - Added unit and integration tests for local memory and generation ID protection. - Configured SpotBugs exclusions filter and updated configuration. Signed-off-by: Jagan Nalla <jagannalla1@gmail.com>
Signed-off-by: Jagan Nalla <jagannalla1@gmail.com>
ef2e098 to
97b11fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses three core enhancement and bug-fix issues across Maestro's runtime, engine, and database layers:
Step Local Memory Support (Maestro add local-memory support #134):
MaestroTaskto ensure local memory is cleared when the step terminates or is canceled.getLocalMemory()inStepRuntimeSummaryfor child step execution contexts to read/write.Generation Guard Data Protection (Leverage generation_id to prevent reverting step data #128):
generation_idcolumn to themaestro_step_instanceschema (migration included).generation_id <= EXCLUDED.generation_idandgeneration_id <= :flowGeneration).Human-in-the-Loop While Loop Breakpoint Support (Human in the loop support for while loop #166):
PAUSEDto theStepRuntime.Statestate machine, allowing step execution to yield back a pause state.StepRuntimeManagerto handlePAUSEDstep status by cleanly callingruntimeSummary.markPaused(...).WhileStepRuntimeto checkstepBreakpointDao.createPausedStepAttemptIfNeeded(...)between iterations. If a breakpoint exists, it yields aPAUSEDstate with timeline event logs.WhileStepRuntime.start(...)to return the existingWhileArtifactdirectly, allowing a seamless resume from the same attempt/iteration without resetting counters or the inner loop's run policy.MaestroStepRuntimeConfiguration.Verification
./gradlew :maestro-engine:test(all pass)../gradlew build -x testand./gradlew spotlessCheck.