The Wayback Machine - https://web.archive.org/web/20211120000424/https://github.com/arduino/arduino-cli/pull/1555
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locale is now refreshed on Init #1555

Merged
merged 1 commit into from Nov 19, 2021
Merged

Locale is now refreshed on Init #1555

merged 1 commit into from Nov 19, 2021
+5 −0

Conversation

@silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Nov 19, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Adds a way for gRPC consumers to refresh the CLI locale without restarting the daemon process.

  • What is the current behavior?

gRPC consumers have no way of changing the language of the CLI without restarting the daemon process.

  • What is the new behavior?

gRPC consumers can now call the Init function to refresh the locale in use.

Nope.

  • Other information:

None.

See how to contribute
@silvanocerza silvanocerza requested a review from Nov 19, 2021
@silvanocerza silvanocerza self-assigned this Nov 19, 2021
@silvanocerza silvanocerza merged commit 39f150a into master Nov 19, 2021
237 checks passed
Loading
@silvanocerza silvanocerza deleted the scerza/reinit-locale branch Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: gRPC type: enhancement
3 participants
@silvanocerza @cmaglie @umbynos