The Wayback Machine - https://web.archive.org/web/20211029142100/https://github.com/TheAlgorithms/Python/pull/4687
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] Fix type annotations for dynamic programming #4687

Merged
merged 3 commits into from Sep 3, 2021
Merged

[mypy] Fix type annotations for dynamic programming #4687

merged 3 commits into from Sep 3, 2021

Conversation

Labels
enhancement
2 participants
@imp2002 @L3str4nge
@imp2002
Copy link
Member

@imp2002 imp2002 commented Aug 28, 2021

Related issue #4052

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
imp2002 added 3 commits Aug 21, 2021
@imp2002
Fix mypy error for knapsack.py
ec2fa65
@imp2002
Fix mypy error for longest_increasing_subsequence
949c946
@imp2002
Fix mypy error for fractional_knapsack_2.py
aad698a
@imp2002 imp2002 requested a review from Kush1101 as a code owner Aug 28, 2021
@L3str4nge L3str4nge merged commit c1b15a8 into TheAlgorithms:master Sep 3, 2021
2 checks passed
shermanhui added a commit to shermanhui/Python that referenced this issue Oct 22, 2021
@imp2002 @shermanhui
[mypy] Fix type annotations for dynamic programming (TheAlgorithms#4687)
b28fd0c 
* Fix mypy error for knapsack.py

* Fix mypy error for longest_increasing_subsequence

* Fix mypy error for fractional_knapsack_2.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment