The Wayback Machine - https://web.archive.org/web/20211029142104/https://github.com/TheAlgorithms/Python/pull/4687/files
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] Fix type annotations for dynamic programming #4687

Merged
merged 3 commits into from Sep 3, 2021
+8 −15
Merged

[mypy] Fix type annotations for dynamic programming #4687

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec2fa65
Fix mypy error for knapsack.py
imp2002 Aug 21, 2021
949c946
Fix mypy error for longest_increasing_subsequence
imp2002 Aug 21, 2021
aad698a
Fix mypy error for fractional_knapsack_2.py
imp2002 Aug 21, 2021
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 dynamic_programming/fractional_knapsack_2.py
View file
Open in desktop
@@ -7,7 +7,7 @@

def fractional_knapsack(
value: list[int], weight: list[int], capacity: int
) -> tuple[int, list[int]]:
) -> tuple[float, list[float]]:
"""
>>> value = [1, 3, 5, 7, 9]
>>> weight = [0.9, 0.7, 0.5, 0.3, 0.1]
@@ -32,8 +32,8 @@ def fractional_knapsack(
ratio = [v / w for v, w in zip(value, weight)]
index.sort(key=lambda i: ratio[i], reverse=True)

max_value = 0
fractions = [0] * len(value)
max_value: float = 0
fractions: list[float] = [0] * len(value)
for i in index:
if weight[i] <= capacity:
fractions[i] = 1
@@ -48,13 +48,6 @@ def fractional_knapsack(


if __name__ == "__main__":
n = int(input("Enter number of items: "))
value = input(f"Enter the values of the {n} item(s) in order: ").split()
value = [int(v) for v in value]
weight = input(f"Enter the positive weights of the {n} item(s) in order: ".split())
weight = [int(w) for w in weight]
capacity = int(input("Enter maximum weight: "))

max_value, fractions = fractional_knapsack(value, weight, capacity)
print("The maximum value of items that can be carried:", max_value)
print("The fractions in which the items should be taken:", fractions)
import doctest

doctest.testmod()
2 dynamic_programming/knapsack.py
View file
Open in desktop
@@ -91,7 +91,7 @@ def knapsack_with_example_solution(W: int, wt: list, val: list):
)

optimal_val, dp_table = knapsack(W, wt, val, num_items)
example_optional_set = set()
example_optional_set: set = set()
_construct_solution(dp_table, wt, num_items, W, example_optional_set)

return optimal_val, example_optional_set
2 dynamic_programming/longest_increasing_subsequence.py
View file
Open in desktop
@@ -36,7 +36,7 @@ def longest_subsequence(array: list[int]) -> list[int]: # This function is recu
pivot = array[0]
isFound = False
i = 1
longest_subseq = []
longest_subseq: list[int] = []
while not isFound and i < array_length:
if array[i] < pivot:
isFound = True