The Wayback Machine - https://web.archive.org/web/20211026015856/https://github.com/TheAlgorithms/Python/pull/4718
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pyupgrade to Python 3.9 #4718

Merged
merged 2 commits into from Sep 7, 2021
Merged

Pyupgrade to Python 3.9 #4718

merged 2 commits into from Sep 7, 2021

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Sep 5, 2021 •
edited

Describe your change:

pyupgrade --py39-plus **/*.py

Next level after #1654 and #3616

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
cclauss and others added 2 commits Sep 5, 2021
@cclauss
Pyupgrade to Python 3.9
de61491
updating DIRECTORY.md
df27fac
@cclauss cclauss requested review from duyuanch and poyea Sep 7, 2021
poyea
poyea approved these changes Sep 7, 2021
View changes
Copy link
Member

@poyea poyea left a comment

Are we enforcing Python 3.9 in other / future PRs?
@cclauss
Copy link
Member Author

@cclauss cclauss commented Sep 7, 2021

No. We did not do so with #1654 and #3616 as well.
@cclauss cclauss merged commit cecf43d into TheAlgorithms:master Sep 7, 2021
4 checks passed
@cclauss cclauss deleted the pyupgrade-py39-plus-again branch Sep 7, 2021
shermanhui added a commit to shermanhui/Python that referenced this issue Oct 22, 2021
@cclauss @shermanhui
Pyupgrade to Python 3.9 (TheAlgorithms#4718)
742e2f8 
* Pyupgrade to Python 3.9

* updating DIRECTORY.md

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
2 participants
@cclauss @poyea