vaadin

Vaadin Framework version: 8, all versions

There is a major error in the class com.vaadin.server.VaadinSession (and possibly other classes too, if this is some kind of cargo cult programming in the Vaadin team)

Most public methods in the class use assertions to "check" if the session has the lock. This is fundamentally wrong. Assertions are the wrong tool to check preconditions in public meth

Description of the bug / feature

Improve the exception message being shows to developers when the app shell annotations are not on top AppShellConfigurator class:

Found app shell configuration annotations in non `AppShellConfigurator` classes.
Please create a custom class implementing `AppShellConfigurator` and move the following annotations to it: ...

1. Give the name of annot

Description

As discovered by @vursen there are some mentions of animation in vaadin-upload-file:

https://github.com/vaadin/web-components/blob/5778f764b4f39d936f3b9af6e7ec92d3023cc1bd/packages/vaadin-upload/src/vaadin-upload-file.js#L176-L184

https://github.com/vaadin/web-components/blob/5778f764b4f39d936f3b9af6e7ec92d3023cc1bd/packages/vaadin-upload/src/vaadin-upload-file.js#L186-L