The Wayback Machine - https://web.archive.org/web/20201008140411/https://github.com/TheAlgorithms/Python/issues/2510
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacktoberfest 2020 - Implement Python algorithms or data structures, fix existing ones and more! #2510

Open
poyea opened this issue Sep 30, 2020 · 32 comments

Comments

@poyea
Copy link
Member

@poyea poyea commented Sep 30, 2020

The annual Hacktoberfest is around the corner! Register on Hacktoberfest's website and open 4 pull requests during October 2020 to receive the swags (if you're the first 70,000 participants)!

In our Python repository, there are currently several open issues:

What's more, you can also fix an existing bugs, improve any documentation and provide better implementations for certain algorithms! Feel free to inform the community by filling an issue and start hacking! If you're new to contributing code, please read our Contribution Guidelines for an overall understanding and ask questions on the internet - Google, StackOverflow or our Gitter.

TheAlgorithms has repositories in other programming languages, so find your language and start coding there!

What you can do to participate

  1. Read our Contribution Guidelines
  2. Comment below or open an issue (for big ideas you may want the community to know) on your new implementations, fixes or functionalities
  3. Start hacking!
  4. Open a pull request for your contribution
  5. Label your pull requests with hacktoberfest
  6. Wait until your pull requests get reviewed or merged! In the meantime, you can review someone else's pull requests too

Useful links

Remarks

  • Please observe Hacktoberfest's rules, terms and FAQ. If a pull request is marked invalid or spam it would not be counted and the person may be disqualified for the swags.
  • Hacktoberfest 2020 is an event presented by DigitalOcean, Intel and DEV.

Hacktoberfest's update

PRs count if:
Submitted in a repo with the hacktoberfest topic AND
during the month of October AND (
The PR is merged OR
The PR is labelled as hacktoberfest-accepted by a maintainer OR
The PR has been approved
)
https://hacktoberfest.digitalocean.com/hacktoberfest-update

@cclauss

Loading…

Member

@cclauss cclauss commented Sep 30, 2020

PSA: I am checking out for the month of Hacktoberfest. I have some important work that I must attend to so I will stop contributing to this repo for the next 30 days. I would encourage maintainers to stick with the rules that have gotten us this far: be friendly, insist on best coding practices including all that is in CONTRIBUTING.md (functions, type hints, doctests, etc.)

If you see PRs that are useless or show that the contributor has not read CONTRIBUTING.md please mark those PRs with the invalid label and close them. (Hacktoberfest organizers look for the invalid label.) Do the same for any contributor who is disrespectful. If we consistently demonstrate that we have high standards and no tolerance for disrespect then the spamers will go elsewhere.

See you again in November.

@Demigod2808 Demigod2808 mentioned this issue Oct 3, 2020
0 of 14 tasks complete
@poyea

Loading…

Member Author

@poyea poyea commented Oct 3, 2020

Please observe that, from now on, a PR has to be marked hacktoberfest-accepted, approved or merged in order to be counted towards the event. For maintainers, please add the labels hacktoberfest-accepted to PRs that are NOT spams, even if you can't review those PRs at the moment. As usual, we label spams as invalid.

https://hacktoberfest.digitalocean.com/hacktoberfest-update

the-kaustubh added a commit to the-kaustubh/Python that referenced this issue Oct 3, 2020
the-kaustubh added a commit to the-kaustubh/Python that referenced this issue Oct 3, 2020
@DmytroLitvinov

Loading…

Contributor

@DmytroLitvinov DmytroLitvinov commented Oct 3, 2020

Hi @poyea ,
Mark please issue #2402 as resolved in the first message of that issue.

@poyea

Loading…

Member Author

@poyea poyea commented Oct 3, 2020

Sure.

@thevirtualbuddy

Loading…

@thevirtualbuddy thevirtualbuddy commented Oct 3, 2020

Hi @poyea & other maintainers,
I am interested to contribute one of my projects to this repository.
The project is a simple CLI application (python based) which has the following functionalities:

  1. Encrypt and encode data in an image.
  2. Decode and decrypt data from an image.

It uses Caesar cipher (encryption & decryption) and Image Steganography(encoding & decoding).

Can I contribute it to this repository?

@poyea

Loading…

Member Author

@poyea poyea commented Oct 3, 2020

Yes. You may also see if there's any related implementation in ciphers.

@thevirtualbuddy

Loading…

@thevirtualbuddy thevirtualbuddy commented Oct 3, 2020

@poyea
Thank you for the quick response.
It has caesar cipher #1958 but it doesn't have image steganography combined with it.
So, should I work on the existing code or work fresh?

Or should I create a new folder as Image Steganography?

@poyea

Loading…

Member Author

@poyea poyea commented Oct 3, 2020

You may add a new one, as the current one works with strings, unless you can modify it make it compatible with images or matrices.

@thevirtualbuddy

Loading…

@thevirtualbuddy thevirtualbuddy commented Oct 3, 2020

Thank you @poyea
I will add a new folder as Image Steganography.

@cclauss

Loading…

Member

@cclauss cclauss commented Oct 3, 2020

Please create a new directory only if there are going to be multiple Python files in it. If it is just a single Python file then please find and existing directory to put it in. We do not want to force visitors to click into and out of tons of directories to find something of interest.

@poyea

Loading…

Member Author

@poyea poyea commented Oct 3, 2020

Yes, add a folder if you have images related to that, but in general, we want to avoid this.

@thevirtualbuddy

Loading…

@thevirtualbuddy thevirtualbuddy commented Oct 3, 2020

I am a bit confused here now :').
If I should add it in Ciphers as caesar_ciphers_with_steganography or create a new folder?

@cclauss

Loading…

Member

@cclauss cclauss commented Oct 3, 2020

How many Python files will your proposed new folder contain?

@thevirtualbuddy

Loading…

@thevirtualbuddy thevirtualbuddy commented Oct 3, 2020

@cclauss I can combine all the files in a single file. Right now, I have the files divided as caesar.py, steganography.py and driver.py
So, only one file.

@cclauss

Loading…

Member

@cclauss cclauss commented Oct 3, 2020

Cool. Then do it whichever way that you think best. Thanks.

@MonarchChakri

Loading…

@MonarchChakri MonarchChakri commented Oct 4, 2020

Hi @cclauss / @poyea
Added file_utils.py under others and created a PR #2735
A utility files helpful for all common file IO.
Please review and merge.

@MonarchChakri MonarchChakri mentioned this issue Oct 4, 2020
8 of 10 tasks complete
@dickyw71

Loading…

Contributor

@dickyw71 dickyw71 commented Oct 4, 2020

Hi @poyea & other maintainers,

I have a fix for issue #1901 and I would like to submit.

My YAML Workflow file auto-closes empty issues.
The file-path name is .github/workflows/auto_close_empty_issues.yml.

The workflow checks whether a new issue body is empty and if so it uses the close-issue action to auto-close the issue and send a notification email to the repo owner/maintainers.

I have tested the Workflow works as expected in my own repo.

Is is ok for me to raise a PR?

@prakhargurunani

Loading…

@prakhargurunani prakhargurunani commented Oct 4, 2020

Hey @cclauss @poyea Can i add some chemical conversitions to /conversions as a part of hacktoberfest ?

@breezko

Loading…

@breezko breezko commented Oct 4, 2020

I’ve added #2782

@dhruvmanila

Loading…

Member

@dhruvmanila dhruvmanila commented Oct 5, 2020

As mentioned, please include for Hacktoberfest or something like that in your description to signal us that this PR is for Hacktoberfest otherwise we wouldn't know that you participated or not.

@dhruvmanila

Loading…

Member

@dhruvmanila dhruvmanila commented Oct 5, 2020

@cclauss @poyea Should we add #2786 and #2695 to Hacktoberfest?

@prakhargurunani

Loading…

@prakhargurunani prakhargurunani commented Oct 5, 2020

@dhruvmanila yeah....for hacktober fest....I am making a PR for conversions

@ChiragBolakani

Loading…

@ChiragBolakani ChiragBolakani commented Oct 5, 2020

Hey @poyea and other maintainers,
I would like to contribute to the web_programming folder with a webscraper which will allow users to scrape presentations and then download them.

@gupta-niharika

Loading…

@gupta-niharika gupta-niharika commented Oct 5, 2020

Hey I'd like to work on one of the issues. I'm a first timer

@poyea

Loading…

Member Author

@poyea poyea commented Oct 6, 2020

Hey @cclauss @poyea Can i add some chemical conversitions to /conversions as a part of hacktoberfest ?

We'd love to see that.

@poyea

Loading…

Member Author

@poyea poyea commented Oct 6, 2020

@cclauss @poyea Should we add #2786 and #2695 to Hacktoberfest?

If the work is original and non-trivial, we should put the tag on it. Ideally, all non-spam PRs should be tagged. Of course, it would be even better if the build passes at the same time.

@mandloiaditi

Loading…

@mandloiaditi mandloiaditi commented Oct 6, 2020

Hi, I would like to implement DSW algorithm to balance binary search tree. May I take up this task and add the implementation to data_structures/binary_tree folder ?

@prakhargurunani

Loading…

@prakhargurunani prakhargurunani commented Oct 6, 2020

I have created a PR #2944 @cclauss @poyea . I have added molecular_chemistry algorithm in /conversions.

@Satyamkumarai

Loading…

@Satyamkumarai Satyamkumarai commented Oct 7, 2020

Hi @poyea
I'd like to contribute to Python/maths/factors.py as part of hactoberfest
I have implemented a fast prime no Generator function
Can i Create a PR?

@bryophyllum1

Loading…

@bryophyllum1 bryophyllum1 commented Oct 7, 2020

HI @poyea, I want to contribute some algorithms during the hacktober, can you assign me, please?

@verdantfire

Loading…

@verdantfire verdantfire commented Oct 7, 2020

I want to add the implementations of Operating Systems scheduling algorithms. Should I add features upon the basic algorithm structure written by @cclauss (to maintain consistency) or use my own?

@SimonLammer

Loading…

@SimonLammer SimonLammer commented Oct 8, 2020

I've opened the PR #2916, is there anything I still have to do moving forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.