The Wayback Machine - https://web.archive.org/web/20201008212711/https://github.com/TheAlgorithms/Python/pull/2893
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Project Euler Problem 01 #2893

Closed
wants to merge 5 commits into from
Closed

Cleanup Project Euler Problem 01 #2893

wants to merge 5 commits into from
+32 −32

Conversation

@CMeza99
Copy link

@CMeza99 CMeza99 commented Oct 6, 2020 •
edited

Describe your change:

  • clean up docstrs
  • add type hints
  • improve coding-style
     
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Part of Issues: #2786, #2510
CMeza99 added 5 commits Oct 6, 2020
@CMeza99
add type hints
Verified
This commit was signed with a verified signature.
CMeza99 Carlos Meza
GPG key ID: 98F86B4E3EB57E33 Learn about signing commits
a5c44cf
@CMeza99
remove unnecessary list comprehension
Verified
This commit was signed with a verified signature.
CMeza99 Carlos Meza
GPG key ID: 98F86B4E3EB57E33 Learn about signing commits
e309fc6
@CMeza99
mv str statement into docstr
Verified
This commit was signed with a verified signature.
CMeza99 Carlos Meza
GPG key ID: 98F86B4E3EB57E33 Learn about signing commits
5597cf0
@CMeza99
rename var to avoid redefining builtin
Verified
This commit was signed with a verified signature.
CMeza99 Carlos Meza
GPG key ID: 98F86B4E3EB57E33 Learn about signing commits
13f5d6a
@CMeza99
clean up module docstr
Verified
This commit was signed with a verified signature.
CMeza99 Carlos Meza
GPG key ID: 98F86B4E3EB57E33 Learn about signing commits
Loading status checks…
ee4ca6e
@aanchal-adk
aanchal-adk approved these changes Oct 6, 2020
View changes
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 6, 2020

Due to #2891, this becomes unnecessary. Thanks for your contribution!
@dhruvmanila dhruvmanila closed this Oct 6, 2020
@CMeza99
Copy link
Author

@CMeza99 CMeza99 commented Oct 6, 2020

@dhruvmanila the type hints was just one commit. the code clean up in the other 4 commits are not desired? FYI, I dropped the type hints commit and rebased off of master if you want reopen and merge these change.
@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 6, 2020

Sure thing, remove the type hints commit and it will be good to go.
Also, why are you disabling flake8?

I cannot reopen as you rebased it.
@CMeza99
Copy link
Author

@CMeza99 CMeza99 commented Oct 6, 2020

will create a new PR. that noqa was a mistake 🤦
@CMeza99 CMeza99 mentioned this pull request Oct 6, 2020
Open
10 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@CMeza99 @dhruvmanila @aanchal-adk
You can’t perform that action at this time.