Bump jackson-core to 2.18.6 in ferstl-depgraph-dependencies (CVE-2025-52999)#21868
Open
Copilot wants to merge 4 commits into
Open
Bump jackson-core to 2.18.6 in ferstl-depgraph-dependencies (CVE-2025-52999)#21868Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
…-52999) - Update 3 maven-fetches.expected files: jackson 2.14.1→2.18.6, jackson-parent 2.14→2.18.4, oss-parent 48→69, plugin version 4.0.3-CodeQL→4.0.3-CodeQL-2 - Update 2 diagnostics.expected files: plugin version reference 4.0.3-CodeQL→4.0.3-CodeQL-2 - Add update-ferstl-depgraph-dependencies.sh auto-update script
Copilot
AI
changed the title
[WIP] Update jackson-core to version 2.15.0 for CVE-2025-52999
Bump jackson-core to 2.18.6 in ferstl-depgraph-dependencies (CVE-2025-52999)
May 19, 2026
oscarsj
approved these changes
May 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the buildless Java extractor’s bundled ferstl-depgraph-dependencies integration-test expectations to reflect a rebuilt depgraph-maven-plugin bundle that pulls in a non-vulnerable Jackson version (addressing CVE-2025-52999), and adds an automation script to reproduce these updates.
Changes:
- Add a new script to rebuild/package the
ferstl/depgraph-maven-plugindependency bundle and rewrite affected*.expectedfiles. - Update
maven-fetches.expectedfixtures to reflect Jackson2.18.6(and updated transitive parent POMs) plus the bumped plugin coordinate4.0.3-CodeQL-2. - Update
diagnostics.expectedfixtures to reflect the new plugin version string in diagnostic messages.
Show a summary per file
| File | Description |
|---|---|
| java/ql/integration-tests/update-ferstl-depgraph-dependencies.sh | New automation script to rebuild the depgraph plugin bundle and update integration-test expected files. |
| java/ql/integration-tests/java/buildless-maven/maven-fetches.expected | Updates expected Maven fetches to new Jackson + plugin coordinate. |
| java/ql/integration-tests/java/buildless-maven-existing-settings-xml/maven-fetches.expected | Same expected-fetch updates for the existing-settings scenario. |
| java/ql/integration-tests/java/buildless-maven-mirrorof/maven-fetches.expected | Same expected-fetch updates for the mirror-of scenario. |
| java/ql/integration-tests/java/buildless-maven-timeout/diagnostics.expected | Updates diagnostic message to reference the new plugin version. |
| java/ql/integration-tests/java/buildless-maven-tolerate-unavailable-dependency/diagnostics.expected | Updates diagnostic message to reference the new plugin version. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 3
Comment on lines
+147
to
+156
| OLD_JACKSON="$(grep -oP 'jackson-core/\K[^/]+(?=/)' "${EXPECTED_FILE}" | head -1)" | ||
| OLD_PLUGIN="$(grep -oP 'depgraph-maven-plugin/\K[^/]+(?=/)' "${EXPECTED_FILE}" | head -1)" | ||
| OLD_OSS_PARENT="$(grep -oP 'fasterxml/oss-parent/\K[^/]+(?=/)' "${EXPECTED_FILE}" | head -1)" | ||
| OLD_JACKSON_PARENT="$(grep -oP 'jackson-parent/\K[^/]+(?=/)' "${EXPECTED_FILE}" | head -1)" | ||
|
|
||
| # Resolve new parent versions from the artifacts Maven just resolved. | ||
| NEW_JACKSON_PARENT="$(find "${LOCAL_REPO}/com/fasterxml/jackson/jackson-parent" \ | ||
| -name "jackson-parent-*.pom" | sort | tail -1 | grep -oP '[\d.]+(?=\.pom)')" | ||
| NEW_OSS_PARENT="$(find "${LOCAL_REPO}/com/fasterxml/oss-parent" \ | ||
| -name "oss-parent-*.pom" | sort | tail -1 | grep -oP '[0-9]+(?=\.pom)')" |
Comment on lines
+153
to
+157
| NEW_JACKSON_PARENT="$(find "${LOCAL_REPO}/com/fasterxml/jackson/jackson-parent" \ | ||
| -name "jackson-parent-*.pom" | sort | tail -1 | grep -oP '[\d.]+(?=\.pom)')" | ||
| NEW_OSS_PARENT="$(find "${LOCAL_REPO}/com/fasterxml/oss-parent" \ | ||
| -name "oss-parent-*.pom" | sort | tail -1 | grep -oP '[0-9]+(?=\.pom)')" | ||
|
|
Comment on lines
+227
to
+231
| echo " 1. Copy ${ZIP_OUT} -> semmle-code resources/lib/ferstl-depgraph-dependencies/ferstl-depgraph-dependencies.zip" | ||
| echo " 2. In semmle-code, update autobuild/src/com/semmle/util/build/Maven.java:" | ||
| echo " bump the plugin version constant to '${PLUGIN_CODEQL_VERSION}'" | ||
| echo " 3. Commit and raise PRs in both repositories." | ||
| trap - EXIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jackson-core2.14.1 bundled inferstl-depgraph-dependenciesis vulnerable to CVE-2025-52999 (StackOverflowError on deeply nested JSON, fixed in 2.15.0). This updates the companiongithub/codeqlintegration-test expected files to match the rebuilt plugin bundle.Expected file updates
The internal semmle-code companion PR rebuilds
depgraph-maven-pluginwith:2.14.1→2.18.6(fixes CVE; aligns with main CodeQL Java dependency set)4.0.3-CodeQL→4.0.3-CodeQL-2(ensures Maven cache invalidation)jackson-parent2.14→2.18.4,com/fasterxml/oss-parent48→69(transitive POM parents)Updated files:
maven-fetches.expected(×3:buildless-maven,buildless-maven-existing-settings-xml,buildless-maven-mirrorof) — new Jackson/oss-parent paths and plugin coordinatediagnostics.expected(×2:buildless-maven-timeout,buildless-maven-tolerate-unavailable-dependency) — plugin version string in diagnostic messagesAuto-update script
Adds
java/ql/integration-tests/update-ferstl-depgraph-dependencies.shto automate future dependency bumps. The script:ferstl/depgraph-maven-pluginat tagdepgraph-maven-plugin-4.0.3pom.xml(version suffix, Guava, Jackson)mvn package install -DskipTests*.expectedfiles in-placeRequires JDK 17, Maven 3.9.x (not 4.x), git, python3.