Integer to Binary Conversion

Question

I'm calculating the conversion from an integer to a binary number wrong. I entered the integer 6 and got back the binary number 0. which is definitely wrong. Can you guys help out? I'm using python 3 by the way.

def ConvertNtoBinary(n):

    binaryStr = ''
    if n < 0:
        print('Value is a negative integer')

    if n == 0:
        print('Binary value of 0 is 0')
    else:
        if n > 0:
            binaryStr = str(n % 2) + binaryStr
            n = n > 1
    return binaryStr

def main():
    n = int(input('Enter a positive integer please: '))
    binaryNumber = ConvertNtoBinary(n)
    print('n converted to a binary number is: ',binaryNumber)

main()

I'm assuming you're doing this either as homework or for your own enjoyment/exercise, which is great. If you just want something that works, use the built-in function bin(). (You may need to strip off the leading 0b from the result, depending on your purposes.) — John Y
– John Y, Commented Mar 13, 2012 at 20:06

mfsiega · Accepted Answer · 2012-03-13 20:17:32Z

3

The problem here is:

n = n > 1

This does the boolean comparison "is n greater than 1?". What you likely want is n >> 1, which bitshifts n.

EDIT: Also, you're only doing this process once - I imagine you'll want to do it on some condition, like

while n > 0:

EDIT2: The comment form John Machin is correct, and I fixed the above to reflect that.

edited Mar 13, 2012 at 20:17

answered Mar 13, 2012 at 19:59

mfsiega

2,87221 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

NateTheSUNYBU_Programmer Over a year ago

I think i got it. Is 6 converted to binary, 110?

mfsiega Over a year ago

indeed it is: (2^0)*0 + (2^1)*1 + (2^2)*1 = 2 + 4 = 6

John Machin Over a year ago

You mean n >> 1 ... n >> 2 divides by 4

Alexander · Accepted Answer · 2012-03-13 20:02:14Z

0

What about the build-in function "bin"?

>>> bin(4711)
'0b1001001100111'

Batteries included!

answered Mar 13, 2012 at 20:02

Alexander

3,7549 gold badges44 silver badges51 bronze badges

Comments

CoffeeRain · Accepted Answer · 2012-03-13 20:03:02Z

0

It depends on what you are doing, but the Python function for doing this is bin(). If you want to convert to binary, you can do bin(numbertoconvert). If you want to convert from binary, you can do int(numbertoconvert, 2). int() takes an optional argument of what base it uses. To get a regular binary number from bin(), you can do int(bin(numbertoconvert)[2:])

answered Mar 13, 2012 at 20:03

CoffeeRain

4,5304 gold badges33 silver badges50 bronze badges

Comments

EricR · Accepted Answer · 2012-03-13 20:03:15Z

0

The problem here is that if n>0, should be a while loop, not an if statement.

answered Mar 13, 2012 at 20:03

EricR

1,4973 gold badges21 silver badges42 bronze badges

Collectives™ on Stack Overflow

Integer to Binary Conversion

4 Answers 4

3 Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

Comments

Comments

Related