PHP - array unset not working in foreach loop

Question

I have various items in my $positions array and do the following:

foreach ($positions as &$position) {

    if ($position['date'] == $order['date']) {
        unset($position);
    }
}
var_dump($positions);

The var_dump still displays the $position which should be excluded.

When I do

foreach ($positions as $key => &$position) {
    if ($position['date'] == $order['date']) {
        unset($positions[$key]);
    }    
}

It does remove far more items than expected.

Anybody knows what happens here in both cases and how why does unset($position) not work? I reference the item in the foreach loop with '&'.

Thanks!

I think I got it. It does remove more items than expected in the second case, because some values are stored like this "-0001-11-30 00:00:00.000000" in the database as the datetime, but I expected everything has a valid date or NULL. — Torben
– Torben, Commented Dec 15, 2017 at 13:10
$positions = array_filter($positions, function($x) { return $x['date'] != '1'; }); — splash58
– splash58, Commented Dec 15, 2017 at 14:55

splash58 · Accepted Answer · 2017-12-15 14:56:19Z

1

Instead of using &$variableName use $varibaleName, because there is not concept of pointers in php and not proper used of reference operator causes unexpected results sometimes.

foreach ($positions as $key => $eachPosition)
{
    if ($eachPosition['date'] == $order['date']) 
    {
        unset(positions[$key]);
    }    
}

edited Dec 15, 2017 at 14:56

splash58

26.2k3 gold badges25 silver badges35 bronze badges

answered Dec 15, 2017 at 13:41

Gaurav Kumar

4362 silver badges8 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Santo Boldizar · Accepted Answer · 2017-12-15 13:15:22Z

0

foreach ($positions as $position) {
  ($position['date'] == $order['date']) ? unset($position['date']) : '';   
}

I hope help you. :)

answered Dec 15, 2017 at 13:15

Santo Boldizar

1,41516 silver badges19 bronze badges

Comments

Nico · Accepted Answer · 2017-12-18 07:00:24Z

0

Assuming you want to delete the $position['date'] value; instead of using unset($positions[$key]) you could do the following :

foreach ($positions as $key => $position) {
    if ($position['date'] == $order['date']) {
        unset($position['date']);
    }    
}

NB : I removed the reference in the foreach loop because according to your example it's not used and can cause unexpected behaviours (PHP foreach by reference causes weird glitch when going through array of objects).

edited Dec 18, 2017 at 7:00

answered Dec 15, 2017 at 13:07

Nico

4694 silver badges20 bronze badges

Collectives™ on Stack Overflow

PHP - array unset not working in foreach loop

3 Answers 3

Comments

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Linked

Related