Ng-click Angular JS doesn't work

Question

In my view

<button type="button"
                ng-disabled="isProcessing"
                ng-click="login.ssoFacebook()"
                class="button button-primary">
                <span class="icon icon-social-facebook"></span>
                Login Using Facebook
            </button>

When I click the button facebook doesn't work My controller

this.ssoFacebook = function(){
        // intiate
        ssoAuth.facebook.initiate()
        .then(function(customer){
            if (!customer) throw 'error system';

            authService.setCurrentSession(customer, $scope);
            $timeout(function() {
                $scope.$emit(GLOBAL_EVENTS.SYSTEM.ACCOUNT.SESSION.LOGIN_SUCCESS);
            }, 500);
            // redirect or something
            $state.go('products', {}, {reload: true});
        })
        .catch(function(error){
            $scope.$emit(GLOBAL_EVENTS.SYSTEM.ACCOUNT.SESSION.LOGIN_FAILED, error);
        });
    };

Am I doing something wrong? thanks advance

What do you mean by not working? Show full controller's code please. — kamil-mrzyglod
– kamil-mrzyglod, Commented Nov 25, 2015 at 9:28
can you post some more code? include the definition of your controller please — Yaron Schwimmer
– Yaron Schwimmer, Commented Nov 25, 2015 at 9:32
@Kamo it doesn't show pop up facebook authenticate, this is my full code controller [plnkr.co/edit/qMI6v34lDklhQmnKvoDs?p=catalogue] — innonx
– innonx, Commented Nov 25, 2015 at 9:35
can you provide how you define login in html? For woking like this with controller somewhere above you should declare ng-controller="Mycontroller as login" — Grundy
– Grundy, Commented Nov 25, 2015 at 9:47
Perhaps it is best to public the complete relevant html, including the ng-controller declaration and your complete controller with only the relevant function apprehended. Maybe you could actually provide more details about the nature of your error, what is your console printing and is there any network activity ongoing? So we can exclude the silly mistake of linking the desired function with your html. — skubski
– skubski, Commented Nov 25, 2015 at 10:58

Abhilash Augustine · Accepted Answer · 2015-11-25 09:40:14Z

1

Replace this code,

this.ssoFacebook = function(){
...
}

with,

$scope.login = {};
$scope.login.ssoFacebook = function(){
..
}

This may be the issue.

answered Nov 25, 2015 at 9:40

Abhilash Augustine

4,2081 gold badge26 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Abhilash Augustine Over a year ago

@did you debug your click?

Grundy · Accepted Answer · 2015-11-25 09:56:04Z

1

If you want use function from controller instead of scope, you need mark this in html in attribute ng-controller

ng-controller="ControllerName as login"

and below you can use

<button type="button"
            ng-disabled="isProcessing"
            ng-click="login.ssoFacebook()"
            class="button button-primary">
            <span class="icon icon-social-facebook"></span>
            Login Using Facebook
</button>

answered Nov 25, 2015 at 9:56

Grundy

13.4k3 gold badges39 silver badges57 bronze badges

2 Comments

skubski Over a year ago

This is actually the only complete answer.

Grundy Over a year ago

@skubski, but seems OP already use it and error somewhere else

leena · Accepted Answer · 2015-11-25 10:45:10Z

0

Change your ng-click to ng-click="ssoFacebook()"

and in your controller change with :

$scope.ssoFacebook = function(){ ... }

answered Nov 25, 2015 at 10:45

leena

3023 silver badges7 bronze badges

1 Comment

skubski Over a year ago

This still wouldn't work if there is no declaration of the ng-controller attribute.

Collectives™ on Stack Overflow

Ng-click Angular JS doesn't work

3 Answers 3

1 Comment

2 Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

1 Comment

Related