JSON to C# object

Question

I have a problem with JSON.

"{"status":"ok","message":"Dane klienta zostau0142y pobrane pomyu015blnie","clientData":
{"id":22,"imie":"Pppppppppp","nazwisko":"Ppppppppppppp","tel":"111111126","email":"[email protected]","ulica":"Na Przyzbie","nr_budynku":"3","nr_lokalu":"41","kod_pocztowy":"02-813","miejscowosc":"Warszawa","samochod_marka":"opel","samochod_model":"vectra","subcategories":
{"6":200}}}"

and it's my class

public class Client
    {
        public string Status { get; set; }
        public string Message { get; set; }
        public Data clientData { get; set; }
    }

    public class Data
    {
        public Dictionary<string, string> clientData { get; set; }
    }

everything is mostly correct but when I debug my code field clientData is null.

What am I doing wrong?

Thanks for help!

EDIT:

it's how I deserialize object.

var myObject = JsonConvert.DeserializeObject<Client>(get_person);

Answer 1

The problem with your current attempt is that you are trying to convert clientData to a Dictionary<string, string>. This is causing an issue because not all of your values are strings, the problematic ones are as follows:

id : int
subcategories : Dictionary<string, int>

If you don't want to explicitly define all of your properties due to them changing without notice, then I would recommend a change to your JSON structure as follows:

{
    "status": "ok",
    "message": "Dane klienta zostau0142y pobrane pomyu015blnie",
    "clientData": {
        "id": 22,
        "properties": {
            "imie": "Pppppppppp",
            "nazwisko": "Ppppppppppppp",
            "tel": "111111126",
            "email": "[email protected]",
            "ulica": "Na Przyzbie",
            "nr_budynku": "3",
            "nr_lokalu": "41",
            "kod_pocztowy": "02-813",
            "miejscowosc": "Warszawa",
            "samochod_marka": "opel",
            "samochod_model": "vectra"
        },
        "subcategories": {
            "6": 200
        }
    }
}

Then you change your C# class structure to the following:

public class Client
{
    public string Status { get; set; }
    public string Message { get; set; }
    public Data clientData { get; set; }
}

public class Data
{
    public int id { get; set;}
    public Dictionary<string, string> properties { get; set; }
    public Dictionary<string, int> subcategories { get; set; }
}

That should work (though I haven't tested), and will hopefully allow you to use it how you need to still.

NOTE: You could also move id and subcategories into the root, and keep clientData as a Dictionary<string, string>. All depends on your preference really, the important thing here is that you be careful not to mix types.

Answer 2

Json

{  
   "status":"ok",
   "message":"Dane klienta zostau0142y pobrane pomyu015blnie",
   "clientData":{  
      "id":22,
      "imie":"Pppppppppp",
      "nazwisko":"Ppppppppppppp",
      "tel":"111111126",
      "email":"[email protected]",
      "ulica":"Na Przyzbie",
      "nr_budynku":"3",
      "nr_lokalu":"41",
      "kod_pocztowy":"02-813",
      "miejscowosc":"Warszawa",
      "samochod_marka":"opel",
      "samochod_model":"vectra",
      "subcategories":{  
         "6":200
      }
   }
}

C# classes

public class Subcategories
{
    public int __invalid_name__6 { get; set; }
}

public class ClientData
{
    public int id { get; set; }
    public string imie { get; set; }
    public string nazwisko { get; set; }
    public string tel { get; set; }
    public string email { get; set; }
    public string ulica { get; set; }
    public string nr_budynku { get; set; }
    public string nr_lokalu { get; set; }
    public string kod_pocztowy { get; set; }
    public string miejscowosc { get; set; }
    public string samochod_marka { get; set; }
    public string samochod_model { get; set; }
    public Subcategories subcategories { get; set; }
}

public class RootObject
{
    public string status { get; set; }
    public string message { get; set; }
    public ClientData clientData { get; set; }
}

Note that root->clientData->subcategories->6 would result in invalid class name, as class names in C# can not begin with a number.

---

With hack fix:

For example:

public class DynamicDictionary : DynamicObject
{
    private readonly Dictionary<string, object> dictionary;

    public DynamicDictionary(Dictionary<string, object> dictionary)
    {
        this.dictionary = dictionary;
    }

    public override bool TryGetMember(
        GetMemberBinder binder, out object result)
    {
        return dictionary.TryGetValue(binder.Name, out result);
    }

    public override bool TrySetMember(
        SetMemberBinder binder, object value)
    {
        dictionary[binder.Name] = value;

        return true;
    }
}

Which can be used as follows:

dynamic x = new DynamicDictionary(
    new Dictionary<string, object> {{"Name", "Peter"}});

Answer 3

you can use Newtonsoft.Json - add a reference to your project and add the using directive

using Newtonsoft.Json;

        //then your code 
        dynamic ma_json = JsonConvert.DeserializeObject<dynamic>(json);
        //and then you can get say the id:
        var id = ma_json.clientData.id; 
        // ... do whatever you want with the id
        if (ma_json.clientData.id == 22) //evaluates to true in your case
        { 
           //do something
        }