PHP Variable into MySQL Query?

Question

I'm having a small problem with my PHP code... I've searched on the forum and copied the code but I must be doing something wrong. I'm trying to order the results I'm getting on a page I have by name, year etc. using a variable. But it isn't working?

I've got this:

$orderby = 'name';    //'$_GET['orderby']' <---- I'd like to use this later to make it dynamic
$req = mysql_query('select id, name, year, genre, cover from table ORDER BY  `table`.`'$orderby'` ASC');

And why isn't the code working? It doesn't give me an error, the page just doesn't load and stays blank!

What, no rants about using $_GET in queries and SQL injection yet? :) — CompuChip
– CompuChip, Commented Dec 28, 2013 at 10:55

olegsv · Accepted Answer · 2013-12-28 10:54:57Z

2

You forgot the concatenation :

$req = mysql_query('select id, name, year, genre, cover from table ORDER BY  `table`.`'.$orderby.'` ASC');

Or

$req = mysql_query("select id, name, year, genre, cover from table ORDER BY  `table`.`$orderby` ASC");

answered Dec 28, 2013 at 10:54

olegsv

1,5171 gold badge15 silver badges21 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Cthulhu · Accepted Answer · 2013-12-28 10:55:07Z

1

Change '$orderby' to '.$orderby.'. . is php concatenation operator.

answered Dec 28, 2013 at 10:55

Cthulhu

1,3711 gold badge13 silver badges26 bronze badges

Comments

David Houde · Accepted Answer · 2013-12-28 10:55:38Z

0

Try

$req = mysql_query('select id, name, year, genre, cover from table ORDER BY  `table`.`' . $orderby . '` ASC');

or

$req = mysql_query('select id, name, year, genre, cover from table ORDER BY  `table`.`$orderby` ASC');

answered Dec 28, 2013 at 10:55

David Houde

4,7881 gold badge22 silver badges29 bronze badges

Collectives™ on Stack Overflow

PHP Variable into MySQL Query?

3 Answers 3

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Related