JavaScript updating an array element with index

Question

I currently have an arrayList() called players in JavaScript in which I push data into it using: players.push({name: msg.name, map: msg.map, coords: msg.coords});

Here is an example data: { name: 'weka', map: '5', coords: '12.4' } for example players[0].

Here is what I am doing:

for (var i = 0; i < players.length; ++i) {
  if (msg.name === players[i].name) {
    console.log("Updating  index ("+i+") player: " + msg.name);
    //players[i].push({name: msg.name, map: msg.map, coords: msg.coords});
  }
}

Robin Castlin · Accepted Answer · 2012-05-16 07:55:15Z

6

players[i].push({name: msg.name, map: msg.map, coords: msg.coords});

should be

players[i] = {name: msg.name, map: msg.map, coords: msg.coords});

You haven't defined players[i] to be an Array, so there's nothing to "push" to. And I asume that you wish to change existing value and not insert an extra depth.

answered May 16, 2012 at 7:55

Robin Castlin

11k1 gold badge30 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Adam Hopkinson Over a year ago

Also, if your key names are the same you can just do players[i] = msg

Potatoswatter Over a year ago

@adam That inserts a reference to msg inside players. Copying the fields over one by one creates an independent new object.

xdazz · Accepted Answer · 2012-05-16 07:56:16Z

2

players.push({name: msg.name, map: msg.map, coords: msg.coords}); is OK,

What you did is players[i].push({name: msg.name, map: msg.map, coords: msg.coords});, players[i] is not an array.

answered May 16, 2012 at 7:56

xdazz

161k38 gold badges255 silver badges278 bronze badges

Comments

hasrthur · Accepted Answer · 2012-05-16 07:56:48Z

0

players[i] - is object ({ name: 'weka', map: '5', coords: '12.4' } for example), not array If you want to set set props just use palyers[i]['prop'] = 'prop';

answered May 16, 2012 at 7:56

hasrthur

1,5101 gold badge15 silver badges35 bronze badges

Collectives™ on Stack Overflow

JavaScript updating an array element with index

3 Answers 3

2 Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Related