Fix PHPUnit 9.x compatibility#2368
Conversation
was using a too old phpunit version
| "sanmai/later": "^0.1.7", | ||
| "sanmai/pipeline": "^7.0", | ||
| "sebastian/diff": "^6.0 || ^7.0", | ||
| "sebastian/diff": "^5.0 || ^6.0 || ^7.0", |
There was a problem hiding this comment.
if we still want to support phpunit 9.x we would have to re-add also ^4.0... are we fine with dropping 9.x which is "End of Bugfix Support" since February 2, 2024?
There was a problem hiding this comment.
Just checked installation stats on packagist.org.
It seems 9.x is the most widely used version and we should still support it
There was a problem hiding this comment.
I'm personally ok with either ways. If we decide to not support 9.x, developers can use older Infection versions.
At least this logic is applied when we got read of non-supported PHP versions each year
There was a problem hiding this comment.
Will add back 9.x support later today. There is no benefit in dropping it atm
|
should be good to go. failling tests seem to be the ones which fail from time to time |
2 participants
the tested started failling because with #2366 we no longer allow old sebastian/diff releases which in turn are required for old phpunit (unintentional side-effect)