Skip to content

feat: add :pid token#329

Merged
jonchurch merged 7 commits into
expressjs:masterfrom
ganesh3367:feature/modernize-and-pid
Dec 9, 2025
Merged

feat: add :pid token#329
jonchurch merged 7 commits into
expressjs:masterfrom
ganesh3367:feature/modernize-and-pid

Conversation

@ganesh3367

@ganesh3367 ganesh3367 commented Nov 30, 2025

Copy link
Copy Markdown
Contributor

Refactors the codebase to use const/let instead of var and adds a :pid token support.

@ganesh3367

This comment was marked as off-topic.

@ganesh3367

This comment was marked as off-topic.

@UlisesGascon UlisesGascon self-assigned this Dec 4, 2025
ganesh3367

This comment was marked as duplicate.

@UlisesGascon

Copy link
Copy Markdown
Member

Hi @ganesh3367!

At the moment, Morgan still supports older Node.js versions such as 0.8, where the const keyword is not available. Would you be able to update the PR to isolate only the :pid-related changes?

It would also be very helpful if you could include some additional context in the PR description to explain the motivation behind this change.

Thanks for your support and contributions!

@ganesh3367

ganesh3367 commented Dec 4, 2025 via email

Copy link
Copy Markdown
Contributor Author
@ganesh3367

Copy link
Copy Markdown
Contributor Author

Yes i did update the PR to isolate only the :pid-related changes

ganesh3367

This comment was marked as off-topic.

@ganesh3367

Copy link
Copy Markdown
Contributor Author

Hello

@jonchurch jonchurch changed the title Refactor var to const/let and add :pid token feat: add :pid token Dec 9, 2025
jonchurch
jonchurch previously approved these changes Dec 9, 2025

@jonchurch jonchurch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you. I pushed a change to add pid to the docs, and reverted a stray whitespace diff in the test file.

@jonchurch jonchurch merged commit f183233 into expressjs:master Dec 9, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants