feat: add :pid token#329
Merged
Merged
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
Hi @ganesh3367! At the moment, Morgan still supports older Node.js versions such as 0.8, where the It would also be very helpful if you could include some additional context in the PR description to explain the motivation behind this change. Thanks for your support and contributions! |
Contributor
Author
|
Hello Sir, thank you for reviewing my PR!
Sure, I will update the PR to isolate only the :pid-related changes and
remove anything that depends on newer Node.js features. I will also add a
clear explanation in the PR description about the motivation behind this
change.
Also, I want to actively contribute to open-source projects, and any
guidance from you would be extremely helpful for me to grow. I really
appreciate your support and feedback.
Thanks again!
…On Thu, 4 Dec 2025 at 12:37, Ulises Gascón ***@***.***> wrote:
*UlisesGascon* left a comment (expressjs/morgan#329)
<#329 (comment)>
Hi @ganesh3367 <https://github.com/ganesh3367>!
At the moment, Morgan still supports older Node.js versions such as 0.8,
where the const keyword is not available. Would you be able to update the
PR to isolate only the :pid-related changes?
It would also be very helpful if you could include some additional context
in the PR description to explain the motivation behind this change.
Thanks for your support and contributions!
—
Reply to this email directly, view it on GitHub
<#329 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BL46S47NBT2W55QQFRHZP73377MSVAVCNFSM6AAAAACNTN2YMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMJQGYYTKMRVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
Yes i did update the PR to isolate only the :pid-related changes |
Contributor
Author
|
Hello |
jonchurch
previously approved these changes
Dec 9, 2025
jonchurch
left a comment
Member
There was a problem hiding this comment.
Looks good, thank you. I pushed a change to add pid to the docs, and reverted a stray whitespace diff in the test file.
jonchurch
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the codebase to use const/let instead of var andadds a :pid token support.