Don't error on symlinks and executables when they don't have to be touched anyway#563
Merged
Conversation
🦋 Changeset detectedLatest commit: 6f0f2b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
approved these changes
Jan 28, 2026
| "@actions/exec": "^1.1.1", | ||
| "@actions/github": "^6.0.1", | ||
| "@changesets/ghcommit": "^2.0.0", | ||
| "@changesets/ghcommit": "2.0.1", |
Member
There was a problem hiding this comment.
Suggested change
| "@changesets/ghcommit": "2.0.1", | |
| "@changesets/ghcommit": "^2.0.1", |
Maybe we should keep the caret
|
thanks @Andarist ! |
ByronDWall
added a commit
to commercetools/merchant-center-application-kit
that referenced
this pull request
Apr 16, 2026
Swaps `dotansimha/changesets-action@v1.5.2` (a ~2-year stale fork) for upstream `changesets/action@v1.7.0`, which is required for `commitMode: "github-api"` support — needed to produce signed changeset commits that satisfy the org-wide "Require signed commits" ruleset (enforced 2026-04-10). Upstream does not ship the fork's `createGithubReleases: aggregate` mode. To preserve the single consolidated GitHub release, this adds a follow-up `scripts/create-aggregate-github-release.sh` that parses `steps.changesets.outputs.publishedPackages` and assembles the release body from each package's CHANGELOG.md. v1.7.0 is specifically required to avoid the "Unexpected executable file" error — earlier versions (including v1.5.3) error on committed executables even when untouched (fixed by changesets/action#563). Closes FEC-828 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ByronDWall
added a commit
to commercetools/ui-kit
that referenced
this pull request
Apr 16, 2026
Swaps `dotansimha/changesets-action@v1.5.2` (a ~2-year stale fork) for upstream `changesets/action@v1.7.0`, which is required for `commitMode: "github-api"` support — needed to produce signed changeset commits that satisfy the org-wide "Require signed commits" ruleset (enforced 2026-04-10). Upstream does not ship the fork's `createGithubReleases: aggregate` mode. To preserve the single consolidated GitHub release, this adds a follow-up `scripts/create-aggregate-github-release.sh` that parses `steps.changesets.outputs.publishedPackages` and assembles the release body from each package's CHANGELOG.md. v1.7.0 is specifically required to avoid the "Unexpected executable file" error — earlier versions (including v1.5.3) error on committed executables even when untouched (fixed by changesets/action#563). Closes FEC-829 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 16, 2026
ByronDWall
added a commit
to commercetools/merchant-center-application-kit
that referenced
this pull request
Apr 16, 2026
…+ aggregate release (#3973) * ci(release): replace dotansimha fork with upstream changesets/action Swaps `dotansimha/changesets-action@v1.5.2` (a ~2-year stale fork) for upstream `changesets/action@v1.7.0`, which is required for `commitMode: "github-api"` support — needed to produce signed changeset commits that satisfy the org-wide "Require signed commits" ruleset (enforced 2026-04-10). Upstream does not ship the fork's `createGithubReleases: aggregate` mode. To preserve the single consolidated GitHub release, this adds a follow-up `scripts/create-aggregate-github-release.sh` that parses `steps.changesets.outputs.publishedPackages` and assembles the release body from each package's CHANGELOG.md. v1.7.0 is specifically required to avoid the "Unexpected executable file" error — earlier versions (including v1.5.3) error on committed executables even when untouched (fixed by changesets/action#563). Closes FEC-828 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * ci(release): call aggregate release script from workflow Replaces the inline bash block with a call to scripts/create-aggregate-github-release.sh (the script was added in the previous commit but the workflow was still inlining the body). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ByronDWall
added a commit
to commercetools/ui-kit
that referenced
this pull request
Apr 16, 2026
…+ aggregate release (#3234) * ci(release): replace dotansimha fork with upstream changesets/action Swaps `dotansimha/changesets-action@v1.5.2` (a ~2-year stale fork) for upstream `changesets/action@v1.7.0`, which is required for `commitMode: "github-api"` support — needed to produce signed changeset commits that satisfy the org-wide "Require signed commits" ruleset (enforced 2026-04-10). Upstream does not ship the fork's `createGithubReleases: aggregate` mode. To preserve the single consolidated GitHub release, this adds a follow-up `scripts/create-aggregate-github-release.sh` that parses `steps.changesets.outputs.publishedPackages` and assembles the release body from each package's CHANGELOG.md. v1.7.0 is specifically required to avoid the "Unexpected executable file" error — earlier versions (including v1.5.3) error on committed executables even when untouched (fixed by changesets/action#563). Closes FEC-829 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * ci(release): call aggregate release script from workflow Replaces the inline bash block with a call to scripts/create-aggregate-github-release.sh (the script was added in the previous commit but the workflow was still inlining the body). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * ci(release): reset tree before canary publish changesets/action in commitMode: github-api runs the `version:` command locally (bumping package.jsons, deleting .changeset/*.md) but commits via the GitHub API without resetting the working tree. The next step's `git checkout main` fails silently on the dirty state, causing canary to publish production version numbers under the canary dist-tag. Fix: hard-reset to origin/main before running canary, and add `set -euo pipefail` so future silent failures become hard stops. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #523