This task involves the work of implementing the calls to action that will accompany the LLM-generated MoS Suggestions that we present during the initial experienced volunteer evaluation phases (T428311 & T431376).
Requirements
Each of the three types of LLM-generated MoS suggestions (revise tone, simplify language, and review place name) will be accompanied by the same CTA...
- Prompt: Do you think this suggestion is valid?
- CTA #1 (Yes, it's valid): hide suggestion; show "Success toast" (see below)
- CTA #2 (No, it's not valid): hide suggestion; show "Keep survey" (see below)
- CTA #1 (Yes, it's valid): hide suggestion; show "Success toast" (see below)
- Success toast:
- Thank you for helping to ensure edit suggestions are reliable and useful.
- Rejection survey:
- Survey description: Please help developers understand why you think this suggestion is invalid.
- Survey options:
- There is an issue in the text, but the type of issue is mislabeled.
- There is an issue in the text, but the suggestion is not helpful.
- None of the above applies.
- Suggestion footer
- Identified using an open-weight language model.
- Logging/Instrumentation
- Each time someone engages with either of the calls to action within the card, ensure that response is logged and associated with its corresponding UUID (T430720)
- This includes which response people provide in the feedback survey.
- Each time someone engages with either of the calls to action within the card, ensure that response is logged and associated with its corresponding UUID (T430720)
Done
- Before implementation begins, ask ML Team for feedback on the proposed technical approach to verify logging will provide info. they need
- Requirements are implemented
- Verify response data is being logged to schema as expected
I checked the related model-generated Suggestion Mode documentation and instrumentation work. One important scope distinction: T430030 owns the suggestion-card copy, while T432666 is specifically about the validation CTAs, feedback flow, footer, and logging. The experimental suggestions cover neutral/tone issues, simpler language, and geographic naming. ([MediaWiki][1])
Derived Requirements
- Ensure that each experimental LLM-generated Revise tone, Simplify language, and Review place name suggestion provides the prompt Do you think this suggestion is valid? with options for the user to indicate that the suggestion is valid or invalid.
- Ensure that when a user indicates an LLM-generated suggestion is valid, the suggestion is dismissed and a success toast displays Thank you for helping to ensure edit suggestions are reliable and useful.
- Ensure that when a user indicates an LLM-generated suggestion is invalid, the suggestion is dismissed and a rejection survey is displayed.
- Ensure that the rejection survey displays Please help developers understand why you think this suggestion is invalid. and provides the following feedback options:
- There is an issue in the text, but the type of issue is mislabeled.
- There is an issue in the text, but the suggestion is not helpful.
- None of the above applies.
- Ensure that each experimental LLM-generated suggestion displays the footer Identified using an open-weight language model.
- Ensure that a user's valid or invalid response is recorded for the specific suggestion with which the user interacted.
- Ensure that feedback selected from the rejection survey is recorded for the specific suggestion being evaluated.
Test Steps
Preconditions
- Use an experienced-user test account eligible for experimental LLM-generated MoS suggestions.
- Enable experimental suggestions if required by the test environment.
- Open an article containing an experimental LLM-generated suggestion.
- Test with Revise tone, Simplify language, and Review place name suggestions when examples of each type are available.
Test Case 1: Ensure all LLM-generated suggestion types provide the validation CTA
- Open an article containing an experimental LLM-generated MoS suggestion.
- Enter VisualEditor.
- Navigate to the LLM-generated suggestion.
- Review the suggestion card.
- Repeat with Revise tone, Simplify language, and Review place name suggestions.
- ✅❓❌⬜ AC1: Each available LLM-generated suggestion type displays "Do you think this suggestion is valid?" with options to indicate that the suggestion is valid or invalid.
Test Case 2: Ensure accepting a valid suggestion displays the success confirmation
- Open an LLM-generated suggestion.
- Locate the Do you think this suggestion is valid? prompt.
- Select the option indicating the suggestion is valid.
- Observe the suggestion and resulting notification.
- ✅❓❌⬜ AC2: Indicating that the suggestion is valid dismisses the suggestion and displays "Thank you for helping to ensure edit suggestions are reliable and useful."
Test Case 3: Ensure rejecting an invalid suggestion displays the feedback survey
- Open an LLM-generated suggestion.
- Locate the Do you think this suggestion is valid? prompt.
- Select the option indicating the suggestion is invalid.
- Observe the suggestion and resulting feedback interface.
- ✅❓❌⬜ AC3: Indicating that the suggestion is invalid dismisses the suggestion and displays the rejection survey.
Test Case 4: Ensure the rejection survey contains the required feedback options
- Open an LLM-generated suggestion.
- Indicate that the suggestion is invalid.
- Review the rejection survey description.
- Review all available survey responses.
- ✅❓❌⬜ AC4: The rejection survey displays "Please help developers understand why you think this suggestion is invalid." with options for a mislabeled issue, an unhelpful suggestion, and "None of the above applies."
Test Case 5: Ensure LLM-generated suggestions identify their model source
- Open an article containing an experimental LLM-generated suggestion.
- Enter VisualEditor.
- Navigate to the suggestion.
- Review the bottom of the suggestion card.
- Repeat with each available LLM-generated suggestion type.
- ✅❓❌⬜ AC5: Each LLM-generated suggestion displays the footer "Identified using an open-weight language model".
Test Case 6: Ensure valid and invalid responses are logged for the correct suggestion
- Open an LLM-generated suggestion with a known UUID.
- Indicate that the suggestion is valid.
- Inspect the corresponding instrumentation event using the available QA logging method.
- Open a different LLM-generated suggestion with a different known UUID.
- Indicate that the second suggestion is invalid.
- Inspect its corresponding instrumentation event.
- ✅❓❌⬜ AC6: Each valid or invalid response is logged with the UUID corresponding to the LLM-generated suggestion on which the response was submitted.
QA Results - TestFlight
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T432666#12229190 |
| 2 | ✅ | T432666#12229148 |
| 3 | ✅ | T432666#12229148 |
| 4 | ✅ | T432666#12229190 |
| 5 | ✅ | T432666#12229190 |
| 6 | ⬜ | T432666#12229190 |











