Description
Details
Related Objects
Event Timeline
Change #1313201 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Add captions to carousel
@JScherer-WMF In the case the caption contains links: do we want to keep the link, or just present the whole thing as plain text?
Same question for whatever other markup (e.g. bold) there may be: strip it or keep it?
@JScherer-WMF In the case the caption contains links: do we want to keep the link, or just present the whole thing as plain text?
Same question for whatever other markup (e.g. bold) there may be: strip it or keep it?
Strip the links from the captions when they're in the carousel please.
@matthiasmullie I added annotated figma specs for the responsive behaviour we discussed earlier. Have a look at the task description and let me know if you have any questions. I haven't tested this out in code yet, so if you could try it out at a bunch of different viewport sizes and let me know if anything looks broken, I would appreciate it!
Change #1313201 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Add captions to carousel
Change #1318199 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Responsive carousel
Change #1318728 had a related patch set uploaded (by Matthias Mullie; author: Matthias Mullie):
[mediawiki/extensions/MultimediaViewer@master] Add additional srcset sizes in carousel
Change #1318199 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Responsive carousel
Change #1318728 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Add additional srcset sizes in carousel
Checked in enwiki beta
For @JScherer-WMF review
- I tested on https://en.wikipedia.beta.wmcloud.org/wiki/Chamber_music (comparing to https://en.wikipedia.org/wiki/Chamber_music and figma design)
- tested on browser mobile emulator
- real physical devices iPhone 11 and Android Samsung S8
- browserstack - iPhone 14 and iPhone 15 (Chrome and Safari)
- also checked for Advanced mode on/off, Expand all sections on/off. text font size setting. dark/light
Summary
FILED as T433865: [iPhone] Captions are cut off in Image carousel (1) The disparity of display on iPhone
Chrome browser simulator displays captions perfectly - iPhone 14 width 430 px (Chrome browser simulator)  | Real physical device - iPhone 11 cuts or doesn't display captions in the carousel  | Browserstack - "real" physical devices - iPhone 14 Chrome/iPhone 15 Chrome/Safari  |
Android:
(2) ❓ Question: should we exclude images from the carousel if they are included into some elements?
https://en.wikipedia.beta.wmcloud.org/wiki/Chamber_music has several quote boxes. One of them (and only one), see below, is presented in the carousel without captions
{{Quote box
|width = 20em
|align = left
|bgcolor = pink
|quote = [[File:Johannes Vermeer - Lady at the Virginal with a Gentleman, 'The Music Lesson' - Google Art Project.jpg|left|150px]]{{YouTube|lGcsNlwTsSw|Quartet lesson}} – Daniel Epstein teaching the Schumann piano quartet at [[Manhattan School of Music]]<br />(Picture: ''[[The Music Lesson]]'' by [[Johannes Vermeer|Jan Vermeer]])}} |  |
(3) ❓ Question: The setting "Enable Media Viewer" in User Preferences - Appearance has a link to old Media Viewer page - https://www.mediawiki.org/wiki/Extension:MultimediaViewer/About. Should it be corrected?
The cascade that the captions are creating is visually disturbing and the articles look like a mess. Do we really want this to become the focal point of every article?
Why, instead, wouldn't you work on showing the full (scrollable) caption in the full screen viewer?
signing off since we have a separate ticket for the cut-off captions issue.
@Ponor thanks for the feedback, our plan is to test a version with captions and a version without to see how readers respond. I think you've also been part of the onwiki discussions--think there will be lots of interesting takeaways in the data to share there :)