Future of filearchive table
Open, Needs TriagePublic

Description

T28741: Migrate file tables to a modern layout (image/oldimage; file/filerevision; add primary keys) does not yet touched the filearchive table. One may expect this table should also be migrated to filerevision, but it depends on how we will do in T20493: RFC: Unify the various deletion systems. This task is just a placeholder before the two subtasks are resolved.

Even if we decided to keep this table, some optimization can be done, such as:

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenLadsgroup
ResolvedKrinkle
ResolvedLadsgroup
Resolvedmforns
ResolvedLadsgroup
ResolvedLadsgroup
ResolvedLadsgroup
ResolvedZabe
ResolvedDreamy_Jazz
ResolvedLadsgroup
ResolvedLadsgroup
DuplicateNone
ResolvedZabe
ResolvedLadsgroup
OpenZabe
OpenPRODUCTION ERRORNone
ResolvedPRODUCTION ERRORZabe
ResolvedPRODUCTION ERRORZabe
ResolvedPRODUCTION ERRORZabe
ResolvedSecurityZabe
ResolvedBUG REPORTLadsgroup
OpenZabe
ResolvedZabe
StalledZabe
ResolvedBUG REPORTManvikesarwani09
OpenNone

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Ladsgroup Should I keep scanning filearchive table to backup deleted files for now? My understanding is currently yes.

Yes. filearchive is not going to be changed at all in the foreseeable future. I don't think the subtasks here are correctly honestly.

One of reasons of T20493: RFC: Unify the various deletion systems is deleting and undeleting pages with many revisions involves moving rows between tables, which is much slower than just update some fields (e.g. moving rows will have larger impact on indices). Previously deleting pages with many revisions is troublesome; T198176: Mediawiki page deletions should happen in batches of revisions mitigates it, but we does not yet have a similar mitigation for undeletion (T239095: Undeleting pages with many revision results in DB exceptions), nor deleting files with many revisions (T425893: MediaWiki is incapable of deleting files with too many versions).

Note deleting files is a heavier operation than deleting pages, since files need to be moved to new location, and in Swift (used by Wikimedia) files can only be moved via copying and deletion.