Userrights special pages layout requires excessive scrolling
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to Special:Userrights or Special:Globaluserrights

What happens?:

  • The layout no greatly expands the page, providing a poor user experience - as even viewing the current settings requires multiple page scrolls even at high resolution

What should have happened instead?:

  • Not sure why this was changed, was it on purpose or a side affect?

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Example:

image.png (958×951 px, 74 KB)

Event Timeline

Tchanders added subscribers: Reedy, mszwarc, Tchanders.

Thanks for the feedback.

We'll remove the "Expires" headers, as laid out in T117884#11394985.

We could also reduce the margin between each checkbox:

OldNew
image.png (499×983 px, 53 KB)
image.png (613×985 px, 52 KB)

Change #1210527 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] UserGroupsSpecialPage: Remove labels from expiry fields

https://gerrit.wikimedia.org/r/1210527

Change #1210528 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Decrease margin on checkboxes on user rights pages

https://gerrit.wikimedia.org/r/1210528

We could also reduce the margin between each checkbox:

OldNew
image.png (499×983 px, 53 KB)
image.png (613×985 px, 52 KB)

That does seem better.

Change #1210527 merged by jenkins-bot:

[mediawiki/core@master] UserGroupsSpecialPage: Remove labels from expiry fields

https://gerrit.wikimedia.org/r/1210527

Change #1210528 merged by jenkins-bot:

[mediawiki/core@master] Decrease margin on checkboxes on user rights pages

https://gerrit.wikimedia.org/r/1210528

This caused accessibility check errors: form elements must be labeled. The check doesn’t say “form elements must be labeled unless the meaning is obvious”, it says they must be labeled, period. I’m honestly surprised OOUI allows skipping the label without even a warning.

Could this decision be reversed, and some other solution be found?

Change #1214632 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] UserGroupsSpecialPage: Restore invisible labels on expiry fields

https://gerrit.wikimedia.org/r/1214632

matmarex subscribed.

The patch above restores the label for screen-readers only, however when testing it I found that it doesn't work in practice. I filed T411676 about that and I'm working on some more patches. Let's continue there.