Create Task
Maniphest T208551

Suppress browser triggered drop down and field highlighting for TitlesMultiselectWidget
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Problem

Browser suggestions are appearing on the 'Pages' field on Special:Block in the TitlesMultiselectWidget widget. This interferes with our valid page name suggestions.

Screen Shot 2018-11-01 at 2.44.34 PM.png (682×1 px, 169 KB)

Acceptance criteria

  • Suppress browser triggered drop down for Pages for TitlesMultiselectWidget
  • Suppress browser triggered field highlighting for Pages for TitlesMultiselectWidget

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
TitlesMultiSelectWidget: pass through 'input' configmediawiki/coremaster+17 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ryasmeen created this task.Nov 1 2018, 10:24 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptNov 1 2018, 10:24 PM
• TBolliger triaged this task as Medium priority.Nov 1 2018, 11:36 PM
• TBolliger moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.
dbarratt renamed this task from Suppress browser triggered drop down for Pages on Special:Block to Suppress browser triggered drop down for TitlesMultiselectWidget.Nov 2 2018, 1:10 AM
dbarratt added a project: MediaWiki-User-management.
dbarratt updated the task description. (Show Details)
• TBolliger moved this task from Backlog to User blocking on the MediaWiki-User-management board.Nov 2 2018, 4:14 PM
• TBolliger updated the task description. (Show Details)Nov 2 2018, 4:24 PM
• TBolliger added a parent task: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.Nov 2 2018, 4:45 PM
dbarratt removed a parent task: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.Nov 2 2018, 5:21 PM
dbarratt added a subtask: T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org.Nov 2 2018, 5:24 PM
• TBolliger mentioned this in T208613: 👩‍👦‍👦 Partial blocks complete blockers for ITWP release.Nov 2 2018, 5:55 PM
dbarratt added a parent task: T208613: 👩‍👦‍👦 Partial blocks complete blockers for ITWP release.Nov 2 2018, 5:59 PM
dbarratt added a project: OOUI.Nov 2 2018, 6:55 PM
• TBolliger moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.Nov 2 2018, 6:57 PM
• TBolliger set the point value for this task to 2.
Volker_E edited projects, added MediaWiki-HTMLForm; removed OOUI.Nov 6 2018, 1:44 AM
Volker_E subscribed.

That can be turned of via 'autocomplete' => 'off' in $a['PageRestrictions'] array resulting in corresponding HTML attribute and value.
Not fully convinced though, how much the suggestions via browser autocomplete are really a problem here. User:RYasmeen_(WMF)/sandbox is a page and might actually speed up filling out the form or am I missing something in the description?

• TBolliger added a comment.Nov 6 2018, 4:21 PM

They interfere with the OOUI drop-down suggestions. I think we should begin with browser suggestions disabled.

• TBolliger renamed this task from Suppress browser triggered drop down for TitlesMultiselectWidget to Suppress browser triggered drop down and field highlighting for TitlesMultiselectWidget.Nov 7 2018, 6:22 PM
• TBolliger updated the task description. (Show Details)
• TBolliger edited projects, added Anti-Harassment-Team (AHT Sprint 33); removed Anti-Harassment-Team.Nov 7 2018, 10:11 PM
Tchanders claimed this task.Nov 12 2018, 12:58 PM
Tchanders moved this task from Ready to In progress on the Anti-Harassment-Team (AHT Sprint 33) board.
gerritbot subscribed.Nov 12 2018, 4:05 PM

Change 473030 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/core@master] TitlesMultiSelectWidget: pass through 'input' config

https://gerrit.wikimedia.org/r/473030

gerritbot added a project: Patch-For-Review.Nov 12 2018, 4:05 PM
Tchanders moved this task from In progress to Review on the Anti-Harassment-Team (AHT Sprint 33) board.Nov 13 2018, 7:31 PM
gerritbot added a comment.Nov 14 2018, 2:01 PM

Change 473030 merged by jenkins-bot:
[mediawiki/core@master] TitlesMultiSelectWidget: pass through 'input' config

https://gerrit.wikimedia.org/r/473030

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 14 2018, 3:01 PM
Tchanders moved this task from Review to Done on the Anti-Harassment-Team (AHT Sprint 33) board.Nov 14 2018, 3:59 PM
dbarratt closed this task as Resolved.Nov 14 2018, 7:55 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 14 2018, 7:55 PM
• TBolliger reopened subtask T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org as Open.Nov 19 2018, 9:50 PM
• TBolliger closed subtask T203821: After QA, enable Partial Blocks MVP on test.wikipedia.org and test.wikidata.org as Resolved.Nov 19 2018, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits