Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

call $e->getRequest() only when it is used at RouteNotFoundStrategy::handleRouteNotFoundError() by move it to the line that actually will use it in next flow #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samsonasik
Copy link
Contributor

  • Is this related to quality assurance?
…handleRouteNotFoundError() by move it to the line that actually will use it in next flow
@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-mvc-console; a new issue has been opened at laminas/laminas-mvc-console#3.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-mvc-console. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-mvc-console to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-mvc-console.
  • In your clone of laminas/laminas-mvc-console, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants