gpui: Defer App::on_action listeners
#33240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
MatinAniss
force-pushed
the
gpui-supply-window
branch
from
3bd62dd to
b40cc9c
Compare
MatinAniss
force-pushed
the
gpui-supply-window
branch
from
b40cc9c to
42993e8
Compare
MatinAniss
changed the title
App::on_action listener
MatinAniss
changed the title
App::on_action listeners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses defer when calling listeners of
App::on_action, this prevents a surprise caused by the double lease when trying to update the window in the callback since it is already being updated.Release Notes: